Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - remove cp ptx file command in gpu burn test #567

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

yukirora
Copy link
Contributor

Description
remove cp ptx file in gpu burn test since the command is run inside self.args.bin_dir dir.

output = run_command(self._commands[cmd_idx], flush_output=self._args.log_flushing, cwd=self._args.bin_dir)

@yukirora yukirora requested a review from a team as a code owner October 23, 2023 09:51
@yukirora yukirora self-assigned this Oct 23, 2023
@yukirora yukirora added the bug Something isn't working label Oct 23, 2023
@yukirora yukirora removed their assignment Oct 23, 2023
@cp5555 cp5555 requested a review from abuccts October 23, 2023 10:41
@cp5555 cp5555 linked an issue Oct 23, 2023 that may be closed by this pull request
@cp5555 cp5555 mentioned this pull request Oct 23, 2023
30 tasks
Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the working dir to run benchmarks is $SB_WORKSPACE, is it changed to bin for all benchmarks? will the behavior affect other benchmarks like ib traffic?

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce3737f) 86.96% compared to head (6c84d07) 86.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   86.96%   86.96%   -0.01%     
==========================================
  Files          93       93              
  Lines        6268     6266       -2     
==========================================
- Hits         5451     5449       -2     
  Misses        817      817              
Flag Coverage Δ
cpu-python3.6-unit-test 71.85% <100.00%> (-0.01%) ⬇️
cpu-python3.7-unit-test 71.85% <100.00%> (-0.01%) ⬇️
cuda-unit-test 84.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukirora yukirora enabled auto-merge (squash) November 14, 2023 03:44
@yukirora yukirora merged commit c7800bb into main Nov 14, 2023
22 of 23 checks passed
@yukirora yukirora deleted the yutji/bug-fix-gpuburn branch November 14, 2023 03:52
@yukirora yukirora mentioned this pull request Dec 6, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default gpu_burn test fails with cp error
4 participants