Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation #586

Merged
merged 48 commits into from
Dec 10, 2023
Merged

Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation #586

merged 48 commits into from
Dec 10, 2023

Conversation

yzygitzh
Copy link
Member

@yzygitzh yzygitzh commented Dec 6, 2023

Description
Add distributed inference benchmark cpp implementation.

Major Revision

  • Add dist_inference.cu for NVIDIA and AMD GPUs.
  • Revise ROCm cmakes.

@yzygitzh yzygitzh requested a review from a team as a code owner December 6, 2023 10:09
@yzygitzh yzygitzh changed the title Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation [WIP] Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation Dec 6, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1f5031b) 86.00% compared to head (c875a81) 86.11%.

Files Patch % Lines
...ench/benchmarks/micro_benchmarks/dist_inference.py 86.56% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   86.00%   86.11%   +0.11%     
==========================================
  Files          97       97              
  Lines        6851     6873      +22     
==========================================
+ Hits         5892     5919      +27     
+ Misses        959      954       -5
Flag Coverage Δ
cpu-python3.6-unit-test 71.81% <13.43%> (-0.15%) ⬇️
cpu-python3.7-unit-test 71.81% <13.43%> (-0.15%) ⬇️
cpu-python3.8-unit-test 72.22% <13.43%> (-0.15%) ⬇️
cuda-unit-test 84.14% <86.56%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yzygitzh yzygitzh requested a review from cp5555 as a code owner December 6, 2023 14:06
@yzygitzh yzygitzh changed the title [WIP] Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation Benchmarks: Microbenchmark - Add distributed inference benchmark cpp implementation Dec 7, 2023
@yzygitzh
Copy link
Member Author

yzygitzh commented Dec 7, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@cp5555 cp5555 mentioned this pull request Dec 9, 2023
Closed
30 tasks
@yzygitzh
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yzygitzh yzygitzh merged commit 719a427 into microsoft:main Dec 10, 2023
20 checks passed
@yzygitzh yzygitzh deleted the ziyue/add-dist-inf-cpp branch December 10, 2023 22:53
@yukirora yukirora mentioned this pull request Dec 14, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp5555 cp5555 cp5555 approved these changes

@abuccts abuccts abuccts approved these changes

Assignees
No one assigned
Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yzygitzh @cp5555 @abuccts