Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add backwards compat for event type #356

Closed
wants to merge 2 commits into from

Conversation

ling1726
Copy link
Member

Adds details as a type for TabsterEventWithDetails for backwards compat. The events are already triggered with the correct details in triggerEvent.

tabster/src/Utils.ts

Lines 1818 to 1820 in 5423336

// For the sake of backward compatibility, we're adding `details` property.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(event as any).details = detail;

Adds `details` as a type for `TabsterEventWithDetails` for backwards
compat. The events are already triggered with the correct details in
triggerEvent.
@ling1726 ling1726 requested a review from mshoho February 15, 2024 07:21
@ling1726 ling1726 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants