some PR feedback

microsoft · Apr 8, 2020 · 1cc1035 · 1cc1035
1 parent 45d9f06
commit 1cc1035
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/.github/actions/spell-check/whitelist/alphabet.txt b/.github/actions/spell-check/whitelist/alphabet.txt
@@ -7,11 +7,9 @@ ABCDEFGHIJ
 abcdefghijk
 abcdefghijklmnop
 ABCDEFGHIJKLMNOPQRST
+ABCDEFGHIJKLMNOPQRSTQ
 abcdefghijklmnopqrstuvwxyz
-QQQQQQQQQQABCDEFGHIJ
-QQQQQQQQQQABCDEFGHIJKLMNOPQRSTQQQQQQQQQ
-QQQQQQQQQQABCDEFGHIJKLMNOPQRSTQQQQQQQQQQ
-QQQQQQQQQQABCDEFGHIJPQRSTQQQQQQQQQQ
+ABCDEFGHIJPQRSTQ
 qrstuvwxyz
 qwerty
 QWERTYUIOP

diff --git a/src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp b/src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp
@@ -49,13 +49,11 @@ namespace TerminalCoreUnitTests
 };
 using namespace TerminalCoreUnitTests;
 
-// Helper for declaring a variable to store a TEST_METHOD_PROPERTY and get it's value from the test metadata
-#define INIT_TEST_PROPERTY(type, identifer, description) \
-    type identifer;                                      \
-    VERIFY_SUCCEEDED(TestData::TryGetValue(L#identifer, identifer), description);
-
 class TerminalCoreUnitTests::ConptyRoundtripTests final
 {
+    // !!! DANGER: Many tests in this class expect the Terminal and Host buffers
+    // to be 80x32. If you change these, you'll probably inadvertently break a
+    // bunch of tests !!!
     static const SHORT TerminalViewWidth = 80;
     static const SHORT TerminalViewHeight = 32;
 

diff --git a/src/host/ut_host/ConptyOutputTests.cpp b/src/host/ut_host/ConptyOutputTests.cpp
@@ -27,6 +27,9 @@ using namespace Microsoft::Console::Types;
 
 class ConptyOutputTests
 {
+    // !!! DANGER: Many tests in this class expect the Terminal and Host buffers
+    // to be 80x32. If you change these, you'll probably inadvertently break a
+    // bunch of tests !!!
     static const SHORT TerminalViewWidth = 80;
     static const SHORT TerminalViewHeight = 32;
 

diff --git a/src/inc/consoletaeftemplates.hpp b/src/inc/consoletaeftemplates.hpp
@@ -17,6 +17,11 @@ Revision History:
 
 #pragma once
 
+// Helper for declaring a variable to store a TEST_METHOD_PROPERTY and get it's value from the test metadata
+#define INIT_TEST_PROPERTY(type, identifer, description) \
+    type identifer;                                      \
+    VERIFY_SUCCEEDED(TestData::TryGetValue(L#identifer, identifer), description);
+
 namespace WEX::TestExecution
 {
     template<>