-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'dev/migrie/f/sui-panes' into dev/migrie/fhl/tasks-pane
- Loading branch information
Showing
260 changed files
with
6,491 additions
and
6,675 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ trigger: | |
| include: | ||
| - main | ||
| - feature/* | ||
| - gh-readonly-queue/* | ||
| paths: | ||
| exclude: | ||
| - doc/* | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
build/pipelines/templates-v2/job-publish-symbols-using-symbolrequestprod-api.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| parameters: | ||
| - name: includePublicSymbolServer | ||
| type: boolean | ||
| default: false | ||
| - name: pool | ||
| type: object | ||
| default: [] | ||
| - name: dependsOn | ||
| type: object | ||
| default: null | ||
| - name: artifactStem | ||
| type: string | ||
| default: '' | ||
| - name: jobName | ||
| type: string | ||
| default: PublishSymbols | ||
| - name: symbolExpiryTime | ||
| type: string | ||
| default: 36530 # This is the default from PublishSymbols@2 | ||
| - name: variables | ||
| type: object | ||
| default: {} | ||
| - name: subscription | ||
| type: string | ||
| - name: symbolProject | ||
| type: string | ||
|
|
||
| jobs: | ||
| - job: ${{ parameters.jobName }} | ||
| ${{ if ne(length(parameters.pool), 0) }}: | ||
| pool: ${{ parameters.pool }} | ||
| ${{ if eq(parameters.includePublicSymbolServer, true) }}: | ||
| displayName: Publish Symbols to Internal and MSDL | ||
| ${{ else }}: | ||
| displayName: Publish Symbols Internally | ||
| dependsOn: ${{ parameters.dependsOn }} | ||
| variables: | ||
| ${{ insert }}: ${{ parameters.variables }} | ||
| steps: | ||
| - checkout: self | ||
| clean: true | ||
| fetchDepth: 1 | ||
| fetchTags: false # Tags still result in depth > 1 fetch; we don't need them here | ||
| submodules: true | ||
| persistCredentials: True | ||
|
|
||
| - task: PkgESSetupBuild@12 | ||
| displayName: Package ES - Setup Build | ||
| inputs: | ||
| disableOutputRedirect: true | ||
|
|
||
| - task: DownloadPipelineArtifact@2 | ||
| displayName: Download all PDBs from all prior build phases | ||
| inputs: | ||
| itemPattern: '**/*.pdb' | ||
| targetPath: '$(Build.SourcesDirectory)/bin' | ||
|
|
||
| - powershell: |- | ||
| Get-PackageProvider -Name NuGet -ForceBootstrap | ||
| Install-Module -Verbose -AllowClobber -Force Az.Accounts, Az.Storage, Az.Network, Az.Resources, Az.Compute | ||
| displayName: Install Azure Module Dependencies | ||
| # Transit the Azure token from the Service Connection into a secret variable for the rest of the pipeline to use. | ||
| - task: AzurePowerShell@5 | ||
| displayName: Generate an Azure Token | ||
| inputs: | ||
| azureSubscription: ${{ parameters.subscription }} | ||
| azurePowerShellVersion: LatestVersion | ||
| pwsh: true | ||
| ScriptType: InlineScript | ||
| Inline: |- | ||
| $AzToken = (Get-AzAccessToken -ResourceUrl api://30471ccf-0966-45b9-a979-065dbedb24c1).Token | ||
| Write-Host "##vso[task.setvariable variable=SymbolAccessToken;issecret=true]$AzToken" | ||
| - task: PublishSymbols@2 | ||
| displayName: Publish Symbols (to current Azure DevOps tenant) | ||
| continueOnError: True | ||
| inputs: | ||
| SymbolsFolder: '$(Build.SourcesDirectory)/bin' | ||
| SearchPattern: '**/*.pdb' | ||
| IndexSources: false | ||
| DetailedLog: true | ||
| SymbolsMaximumWaitTime: 30 | ||
| SymbolServerType: 'TeamServices' | ||
| SymbolsProduct: 'Windows Terminal Converged Symbols' | ||
| SymbolsVersion: '$(XES_APPXMANIFESTVERSION)' | ||
| SymbolsArtifactName: 'WindowsTerminal_$(XES_APPXMANIFESTVERSION)' | ||
| SymbolExpirationInDays: ${{ parameters.symbolExpiryTime }} | ||
| env: | ||
| LIB: $(Build.SourcesDirectory) | ||
|
|
||
| - pwsh: |- | ||
| # Prepare the defaults for IRM | ||
| $PSDefaultParameterValues['Invoke-RestMethod:Headers'] = @{ Authorization = "Bearer $(SymbolAccessToken)" } | ||
| $PSDefaultParameterValues['Invoke-RestMethod:ContentType'] = "application/json" | ||
| $PSDefaultParameterValues['Invoke-RestMethod:Method'] = "POST" | ||
| $BaseUri = "https://symbolrequestprod.trafficmanager.net/projects/${{ parameters.symbolProject }}/requests" | ||
| # Prepare the request | ||
| $expiration = (Get-Date).Add([TimeSpan]::FromDays(${{ parameters.symbolExpiryTime }})) | ||
| $createRequestBody = @{ | ||
| requestName = "WindowsTerminal_$(XES_APPXMANIFESTVERSION)"; | ||
| expirationTime = $expiration.ToString(); | ||
| } | ||
| Write-Host "##[debug]Starting request $($createRequestBody.requestName) with expiration date of $($createRequestBody.expirationTime)" | ||
| Invoke-RestMethod -Uri "$BaseUri" -Body ($createRequestBody | ConvertTo-Json -Compress) -Verbose | ||
| # Request symbol publication | ||
| $publishRequestBody = @{ | ||
| publishToInternalServer = $true; | ||
| publishToPublicServer = $${{ parameters.includePublicSymbolServer }}; | ||
| } | ||
| Write-Host "##[debug]Submitting request $($createRequestBody.requestName) ($($publishRequestBody | ConvertTo-Json -Compress))" | ||
| Invoke-RestMethod -Uri "$BaseUri/$($createRequestBody.requestName)" -Body ($publishRequestBody | ConvertTo-Json -Compress) -Verbose | ||
| displayName: Publish Symbols using internal REST API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| Get-ChildItem -Recurse -Filter *.resw | ||
| | Where-Object { $_.Directory.Name.StartsWith("qps-ploc") } | ||
| | ForEach-Object { | ||
| $source = Join-Path $_.Directory "../en-US/$($_.Name)" | ||
| $target = $_ | ||
|
|
||
| $ploc = ./tools/ConvertTo-PseudoLocalization.ps1 -Path $source | ||
|
|
||
| $writerSettings = [System.Xml.XmlWriterSettings]::new() | ||
| $writerSettings.NewLineChars = "`r`n" | ||
| $writerSettings.Indent = $true | ||
| $writer = [System.Xml.XmlWriter]::Create($target, $writerSettings) | ||
| $ploc.Save($writer) | ||
| $writer.Flush() | ||
| $writer.Close() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
727b051There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@check-spelling-bot Report
🔴 Please review
See the 📜action log or 📝 job summary for details.
Unrecognized words (5)
actiopn
ifying
sxnui
taskpane
tbh
Previously acknowledged words that are now absent
AAAa Jsons vtapi 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands
... in a clone of the git@github.com:microsoft/terminal.git repository
on the
dev/migrie/fhl/tasks-panebranch (ℹ️ how do I use this?):Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary
This includes both expected items (2225) from .github/actions/spelling/expect/04cdb9b77d6827c0202f51acd4205b017015bfff.txt
.github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt and unrecognized words (5)
Consider adding them (in
.github/workflows/spelling2.yml) foruses: check-spelling/check-spelling@v0.0.22in itswith:To stop checking additional dictionaries, add (in
.github/workflows/spelling2.yml) foruses: check-spelling/check-spelling@v0.0.22in itswith:Errors (1)
See the 📜action log or 📝 job summary for details.
See ❌ Event descriptions for more information.
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
.github/actions/spelling/allow/names.txt..github/actions/spelling/allow/..github/actions/spelling/expect/..github/actions/spelling/patterns/.See the
README.mdin each directory for more information.🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using).well-formed pattern.
If you can write a pattern that would match it,
try adding it to the
patterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.