Skip to content

Commit

Permalink
Add a spec for the Command Palette (#2193)
Browse files Browse the repository at this point in the history 
* Add a spec for the Command Palette

  specs #2046.

* Apply suggestions from code review

Co-Authored-By: Carlos Zamora <carlos.zamora@microsoft.com>

* * Add note from Carlos about UIA
* Add a note about nested commands

* fix Michael's comments

* Move to `doc/specs/`

* Apply suggestions from code review

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

* Add updates from Dustin

  esp. considering keybindings args, localization

* add notes about expanding profiles, localization

* move this spec to the drafts folder

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
  • Loading branch information
@zadjii-msft @carlos-zamora @DHowett
3 people committed Apr 13, 2020
1 parent ea1bb2e commit ffbdfe3
Showing 1 changed file with 427 additions and 0 deletions.

1 comment on commit ffbdfe3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • aditionally
  • algorithim
  • aslo
  • charater
  • commadline
  • ertical
  • Esentially
  • gitlab
  • Hackathon
  • pallete
  • particualr
  • plit
  • recieve
  • thoguh
  • validator
To accept these changes, run the following commands 
remove_obsolete_words=$(mktemp)
echo '#!/usr/bin/perl -ni
my $re=join "|", qw('"
aaaaa
aaaaaa
aaaaaaaaaaaaaaaaaaa
ABCDEFGHIJKLMNOPQRSTQ
ABCDEFGHIJPQRST
ABCDEFGHIJPQRSTQ
APPLOGIC
BBBB
BBBBBBBBBBBBBBBBBBBBBBBBBB
CCCC
DDDD
EEEE
ffff
ggggg
gggggg
ggggggg
LLLLLLLL
QQQQ
RRRRRRR
Spc
unicodechar
usr
xxxx
"');
next if /^($re)(?:$| .*)/;
print;' > $remove_obsolete_words
chmod +x $remove_obsolete_words
for file in .github/actions/spell-check/whitelist/alphabet.txt .github/actions/spell-check/whitelist/web.txt .github/actions/spell-check/whitelist/whitelist.txt; do $remove_obsolete_words $file; done
rm $remove_obsolete_words
(
echo "
aditionally
algorithim
applogic
aslo
charater
commadline
ertical
Esentially
gitlab
Hackathon
pallete
particualr
plit
recieve
thoguh
validator
"
) | sort -u -f | perl -ne 'next unless /./; print' > new_whitelist.txt && mv new_whitelist.txt '.github/actions/spell-check/whitelist/ffbdfe32ac972ecf76ead140a2ae5bad59cf6f91.txt'
✏️ Contributor please read this
  • If the items listed above are names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • If they're APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • If they're just things you're using, please add them to an appropriate file in .github/actions/spell-check/whitelist/.
  • If you need to use a specific token in one place and it shouldn't generally be used, you can
    add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.