Nested previewable commands don't "cancel" when you navigate up the nesting stack #10165
Labels
Area-CmdPal
Command Palette issues and features
Help Wanted
We encourage anyone to jump in on these.
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Priority-3
A description (P3)
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
ghost
added
Needs-Triage
|
okay good catch |
zadjii-msft
added
Help Wanted
DHowett
removed
the
Needs-Triage
6 tasks
ghost
added
Resolution-Fix-Committed
ghost
pushed a commit
that referenced
this issue
Jun 14, 2021
…10392) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Immediately cancelling the preview when the user is navigating back from a nested command. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #10165 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Basically 2 changes are done here: - Allow the click handler to run for the back button when the button has focus and user hits the enter key (similarly as hitting space now). - Now immediately cancelling the preview when the user is navigating back. Felt nicer to do it immediately at that point then keeping the preview active until the user hits cancel to close the palette. So the preview is already cancelled at step **5** instead of 6 as mentioned in the reproduction steps here #10165 (comment). But of course let me know if you're not agreeing here 😀 . <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Open 'Color Scheme' and verified preview is still working fine when selecting different schemes. - After tabbing back to the Back button verified that when hitting enter or space the preview is cancelled and the original color scheme is being used again. - Then after going back to 'Color Scheme' previews are still working ok. - After hitting Enter on one of the Color Schemes the scheme still becomes active as before.
DHowett
pushed a commit
that referenced
this issue
Jul 7, 2021
…10392) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Immediately cancelling the preview when the user is navigating back from a nested command. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #10165 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Basically 2 changes are done here: - Allow the click handler to run for the back button when the button has focus and user hits the enter key (similarly as hitting space now). - Now immediately cancelling the preview when the user is navigating back. Felt nicer to do it immediately at that point then keeping the preview active until the user hits cancel to close the palette. So the preview is already cancelled at step **5** instead of 6 as mentioned in the reproduction steps here #10165 (comment). But of course let me know if you're not agreeing here 😀 . <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Open 'Color Scheme' and verified preview is still working fine when selecting different schemes. - After tabbing back to the Back button verified that when hitting enter or space the preview is cancelled and the original color scheme is being used again. - Then after going back to 'Color Scheme' previews are still working ok. - After hitting Enter on one of the Color Schemes the scheme still becomes active as before. (cherry picked from commit 1cc383f)
DHowett
pushed a commit
that referenced
this issue
Jul 7, 2021
…10392) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Immediately cancelling the preview when the user is navigating back from a nested command. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #10165 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Basically 2 changes are done here: - Allow the click handler to run for the back button when the button has focus and user hits the enter key (similarly as hitting space now). - Now immediately cancelling the preview when the user is navigating back. Felt nicer to do it immediately at that point then keeping the preview active until the user hits cancel to close the palette. So the preview is already cancelled at step **5** instead of 6 as mentioned in the reproduction steps here #10165 (comment). But of course let me know if you're not agreeing here 😀 . <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Open 'Color Scheme' and verified preview is still working fine when selecting different schemes. - After tabbing back to the Back button verified that when hitting enter or space the preview is cancelled and the original color scheme is being used again. - Then after going back to 'Color Scheme' previews are still working ok. - After hitting Enter on one of the Color Schemes the scheme still becomes active as before. (cherry picked from commit 1cc383f)
|
🎉This issue was addressed in #10392, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #10392, which has now been successfully released as Handy links: |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version (or Windows build number)
1.8, 1.9
Other Software
No response
Steps to reproduce
<buttonExpected Behavior
No response
Actual Behavior
The preview scheme is stuck!
The text was updated successfully, but these errors were encountered: