Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell extension not available in folders which have "Libraries" as a root #10421

Closed
AlphaModder opened this issue Jun 13, 2021 · 5 comments
Closed
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Tracking-External This bug isn't resolved, but it's following an external workitem.

Comments

@AlphaModder
Copy link

AlphaModder commented Jun 13, 2021

Windows Terminal version (or Windows build number)

1.9.1523.0

Other Software

No response

Steps to reproduce

  • Go to a folder where the address bar displays This PC as the root in explorer (e.g. This PC > OS (C:) > MyFolder)
  • Right click on the background. Verify that the Open in Windows Terminal menu item is present.
  • Switch to a directory that is located inside a library (e.g. Libraries > Documents > MyFolder).
  • Right click on the background (not a subfolder). The menu item no longer appears.

Expected Behavior

For a context menu like this to appear:
image

Actual Behavior

A context menu like this appears:
image

Notes

  • This issue does not occur if the library is accessed through This PC, as in This PC > Documents > MyFolder
  • With a registry-based shell extension, I think the solution would be to add a subkey under HKEY_CLASSES_ROOT\LibraryFolder\background\shell\, in addition to HKEY_CLASSES_ROOT\Directory\background\shell\. I'm not sure how this translates to the COM-based shell extension API.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 13, 2021
@DHowett DHowett added Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jun 14, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 14, 2021
@DHowett
Copy link
Member

DHowett commented Jun 14, 2021

Good catch. Thanks!

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 14, 2021
@DHowett DHowett added this to the Terminal v2.0 milestone Jun 14, 2021
@KalleOlaviNiemitalo
Copy link

On a related note… the Windows Terminal shell extension is available when I right-click the "Libraries" node in the navigation pane, but if I try to use it, I just get an error: "The parameter is incorrect."

@zadjii-msft
Copy link
Member

Filed this upstream at MSFT:35409337. I'm not sure we're ever even getting Invoked in this scenario, so we might not have any chance at hacking our way around this one.

@zadjii-msft zadjii-msft added the Tracking-External This bug isn't resolved, but it's following an external workitem. label Aug 18, 2021
@zadjii-msft
Copy link
Member

On Windows 11, I've seen that this will work when trying a folder inside a library, but not directly within the library itself. For example:
In "Libraries/Pictures"
image

but in Libraries\Pictures\screenshots (which does get resolved to %userprofile%\onedrive\pictures\screenshots):
image


The Explorer team did get back to me on this:

Libraries are not an actual location. They are virtual. They represent a merge of multiple locations. This is why you don't see "open in terminal" at the root of a library. There is not a place to open to in this case. Likewise, once you navigate into a folder within a library, you are now in an actual folder location, which is why you do see the option there.

Therefore, this is working as designed.

So, I guess we're gonna close this one out.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2021
@zadjii-msft zadjii-msft added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Aug 23, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2021
@AlphaModder
Copy link
Author

@zadjii-msft Are there plans to backport the fix for the case for folders within a library (e.g. Libraries/Pictures/Screenshots) to Windows 10?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Development

No branches or pull requests

4 participants