Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conpty needs to render the on/off state of the cursor #1127

Closed
zadjii-msft opened this issue Jun 3, 2019 · 3 comments · Fixed by #2829
Closed

Conpty needs to render the on/off state of the cursor #1127

zadjii-msft opened this issue Jun 3, 2019 · 3 comments · Fixed by #2829
Assignees
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@zadjii-msft
Copy link
Member

This is a followup from #1087. I don't render the right state out through conpty, and that means that for tools like apt, the cursor is always on, even when they want it off.

@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Conpty For console issues specifically related to conpty Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jun 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 3, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 3, 2019
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 3, 2019
@DHowett-MSFT DHowett-MSFT changed the title Conpty need to render the blinking state of the cursor Conpty need to render the on/off state of the cursor Jun 11, 2019
@DHowett-MSFT DHowett-MSFT changed the title Conpty need to render the on/off state of the cursor Conpty needs to render the on/off state of the cursor Jun 11, 2019
@utybo
Copy link

utybo commented Sep 13, 2019

I'm experiencing the same issue as #1461, which redirects to here.

Any update on this?

Here is an example C# code:

    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Now you see me!");
            Console.CursorVisible = true;
            Console.ReadLine();
            
            Console.CursorVisible = false;
            Console.WriteLine("Now you don't!");
            Console.ReadLine();
        }
    }

image
image
In the second image, the cursor is at the very end of the line

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.0, 20H1 Sep 16, 2019
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Sep 16, 2019
@zadjii-msft
Copy link
Member Author

Good catch, this we incorrectly marked for Terminal v1.0 when it's really a 20H1 fix.

@zadjii-msft zadjii-msft self-assigned this Sep 16, 2019
zadjii-msft added a commit that referenced this issue Sep 20, 2019
@ghost ghost added the In-PR This issue has a related PR label Sep 20, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 4, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #2829, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants