Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12] Settings UI Nits #11352

Closed
5 of 8 tasks
zadjii-msft opened this issue Sep 28, 2021 · 2 comments · Fixed by #11391
Closed
5 of 8 tasks

[1.12] Settings UI Nits #11352

zadjii-msft opened this issue Sep 28, 2021 · 2 comments · Fixed by #11391
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Sep 28, 2021 •
edited
Loading

discovered in the 1.12 bug bash on 9/28

A collection of SUI nits that we should do for 1.12.

  • image This setting should probably be something like "Startup behavior", rather than an incomplete sentence
    • Veto'd, because image
  • [Actions page] The 'S' in the "Open Settings" action is unnecessarily capitalized
  • "Clear Buffer" Should be a lowercase b on buffer
  • "Background Opacity" above the slider should have a lowercase "o"
  • image Unspecified error when adding "opacity": 0.7 to JSON
  • This padding's gotta go: image
  • [Appearance tab of a profile] "Reset to inherited value" button doesn't show up for the background opacity slider after moving the slider (unless you hit 'Save' after making the change)
  • [Appearance tab of a profile] "Reset to inherited value" button for the background opacity slider shows up despite hitting 'Discard changes' after moving the slider
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings UI Anything specific to the SUI labels Sep 28, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 28, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 28, 2021
@zadjii-msft zadjii-msft self-assigned this Sep 28, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 28, 2021
Merged
3 tasks
@zadjii-msft zadjii-msft removed their assignment Sep 28, 2021
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Sep 28, 2021 •
edited
Loading

Both the sliders are a little weird. Unsure why that is right now. Presumably there's a similar root cause?

I'm hoping that they go away when we figure out #11355 EDIT: they did not

ghost pushed a commit that referenced this issue Sep 29, 2021
@zadjii-msft
Minor typos in 1.12 features in SUI (#11362)
6939112 
* [x] Fixes a bunch of the checkboxes in #11352
* [x] Fixes one of the boxes in #11353
* [x] The opacity warning -> error gibberish was fixed with the change to `DeserializationError` - `asCString` only works if the `JsonValue` is a string already.
@ianjoneill ianjoneill mentioned this issue Oct 1, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 1, 2021
@ghost ghost closed this as completed in #11391 Oct 4, 2021
ghost pushed a commit that referenced this issue Oct 4, 2021
@ianjoneill
Ensure "Reset to inherited value" button works for opacity (#11391)
703e349 
## Summary of the Pull Request
Fixes the "Reset to inherited value" button for the opacity slider and removes the unwanted padding between the header and the control.

## PR Checklist
* [x] Closes #11352
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
Manually tested
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 4, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11391, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Ensure "Reset to inherited value" button works for opacity ianjoneill/terminal
1 participant
@zadjii-msft