Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AltGr + Space combination doesn’t work all of a sudden #11649

Closed
pzehner opened this issue Oct 29, 2021 · 17 comments
Closed

AltGr + Space combination doesn’t work all of a sudden #11649

pzehner opened this issue Oct 29, 2021 · 17 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@pzehner
Copy link

pzehner commented Oct 29, 2021

Windows Terminal version (or Windows build number)

1.11.*

Other Software

French Bépo keyboard layout.

Steps to reproduce

Using the French Bépo keyboard layout, I type the underscore key "_" with AltGr + Space.

Expected Behavior

Usually it just works.

Actual Behavior

Today, without any updates or changes in configuration, MS Terminal doesn’t type the character any more. Other AltGr combinations work, but not this one. Any other application (including PowerShell and CMD) can type the character normally.

Note: It is more likely that this behaviour started with the 1.11 version. 1.10.2714.0 is the latest behaving correctly.

Note 2: "all of a sudden" because MS Terminal updates itself automatically and I could not find a way to prevent that.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 29, 2021
@nchataing
Copy link

Same here : by manually switching to the previous release it works again

@DHowett
Copy link
Member

DHowett commented Oct 29, 2021

@lhecker @PankajBhojwani this is related to us binding alt+space to the system menu by default. Did we regress Alt/AltGr aliasing somehow?

@arthaud
Copy link

arthaud commented Oct 30, 2021

Same here.
By the way, hello Paul :)

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Nov 4, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 4, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Nov 4, 2021
@zadjii-msft zadjii-msft added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Nov 4, 2021
@Siphonay
Copy link

Siphonay commented Nov 5, 2021

I am also encountering this issue

@at-github
Copy link

Same as well, i didn’t see shortcut overwriting this combination

@pzehner
Copy link
Author

pzehner commented Nov 10, 2021

I confirm that the problem does not appear by manually downgrading to 1.10.2714.0.

@crequill
Copy link

I have the same problem with terminal 1.11.2921.0 but it’s corrected in terminal 1.12.2931.0.

@Geobert
Copy link

Geobert commented Nov 15, 2021

Same issue for me, bépo as well. It's very annoying as it's how we type _ (underscore) in this layout :-/

@Siphonay
Copy link

Can confirm the issues seems to be fixed in Preview Release 1.12.2931.0

@chikamichi
Copy link

chikamichi commented Nov 21, 2021

A few days back, I installed 1.12.2931.0 and it seemed to be fixed. But all of a sudden, in stopped working. No tooling/version change, no keyboard layout change.

@lhecker
Copy link
Member

lhecker commented Nov 23, 2021

Hmm indeed this is hard to reproduce... I've downloaded the portable version and AltGr+Space produces "_".

@Siphonay
Copy link

Siphonay commented Nov 23, 2021

Hmm indeed this is hard to reproduce... I've downloaded the portable version and AltGr+Space produces "_".

Be aware that the portable version is a PKL, which are repackaged AutoHotKey scripts, and not a proper keyboard layout per se, so this and the actual Windows keyboard layout package may exhibit different behavior

@pzehner
Copy link
Author

pzehner commented Nov 26, 2021

Even downgrading the terminal to the latest 1.10 version and pinning it (I am using Chocolatey), the application automatically updates itself like once a week and I end with the broken 1.11 version…

@ghost ghost added the In-PR This issue has a related PR label Nov 27, 2021
@lhecker
Copy link
Member

lhecker commented Nov 27, 2021

This line was introduced in the 1.11 branch with #10988 and should say IsLeftAltPressed() (if we had that):

if (vkey == VK_SPACE && modifiers.IsAltPressed())

In the 1.12 branch we switched to using regular actions with #11086. Since actions are never run for AltGr key combinations, this fixes the issue for 1.12 and later.
For 1.11 I fixed this issue in #11832. The fix isn't particularly beautiful, but I believe it's enough for an older release like that. 😅

zadjii-msft pushed a commit that referenced this issue Dec 1, 2021
This fixes a regression introduced in #10988 for the 1.11 release branch.
For later branches this issue was fixed in #11086.

## PR Checklist
* [x] Closes #11649
* [x] I work here
* [x] Tests added/passed

## Validation Steps Performed
* AltGr+Space produces "_" with the bépo keyboard layout
@ghost ghost removed the In-PR This issue has a related PR label Dec 1, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Dec 1, 2021
@Dragnalith
Copy link

Dragnalith commented Dec 2, 2021

same problem here with version 1.11.2921.0

EDIT: I confirm it is fixed in Windows Terminal Preview (1.12.2931.0)

@DHowett DHowett removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Dec 13, 2021
@DHowett
Copy link
Member

DHowett commented Dec 13, 2021

This fix merged into release-1.11 and will be released shortly. 😄

@DHowett DHowett closed this as completed Dec 13, 2021
@ghost
Copy link

ghost commented Dec 14, 2021

🎉This issue was addressed in #11832, which has now been successfully released as Windows Terminal v1.11.3471.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

No branches or pull requests