Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT color displayed on Windows Terminal leaks to the rest of line when resizing the terminal window #11742

Closed
daxian-dbw opened this issue Nov 12, 2021 · 6 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@daxian-dbw
Copy link
Member

Windows Terminal version (or Windows build number)

1.12.2931.0

Other Software

This is not related to the application that uses Windows Terminal. You can reproduce this with bash in WSL or PowerShell.

Steps to reproduce

In PowerShell, do the following:

  1. Run "`e[44;1mYEAH YEAH YEAH YEAH`e[0m"
  2. Resize the window
  3. The color gets leaked to the rest of line

Animation

Similar in bash in WSL:

Animation

Expected Behavior

Given that the string written out ends with ESC[0m to unset all attributes, the color should not leak to the rest of line when resizing window.

Actual Behavior

The color gets leaked to the rest of line when resizing happens.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 12, 2021
@elsaco
Copy link

elsaco commented Nov 13, 2021

@daxian-dbw alacritty does it also:

alacritty_prompt_test

@daxian-dbw
Copy link
Member Author

The leak doesn't happen when I do the same on macOS or Ubuntu:

Animation

PowerShell adopts colors in its formatting, but when there is any resize of the window, the background color will be leaked to rest line and make it look really bad. It would be nice to fix this in Windows Terminal.

image

@j4james
Copy link
Collaborator

j4james commented Nov 13, 2021

I'm afraid this is a known problem. Second oldest open issue in the repo actually. See #32.

Technically that's tagged as a conhost issue, but that's only because it was a couple of year before Windows Terminal was even released. I'm fairly certain the underlying cause is the same in both conhost and WT.

@daxian-dbw
Copy link
Member Author

Thanks @j4james, I didn't find that issue before opening this one. Maintainers can close this one as a duplicate.
It's a little disappointing to see #32 is marked with "Priority-3". Wish it can be addressed sooner.

@zadjii-msft
Copy link
Member

/dup #32

It's a little disappointing to see #32 is marked with "Priority-3". Wish it can be addressed sooner.

Alas, it's a combination of "It's a hard bug to fix" combined with "it's not that impactful". If anyone's got clever ideas of how to solve that, we're all ears! We suspect it'll just get better when #8000 is finished as well, though it's anyone's guess when that'll be done.

@ghost
Copy link

ghost commented Nov 15, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 15, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants