Console doesn't handle colored regions when reflowed #32

bitcrazed · 2017-10-06T17:01:38Z

Your Windows build number: (Type ver at a Windows Command Prompt)
FCU
What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

Open Ubuntu session in Console
Execute the following:

$ cd ~/
$ mkdir temp
$ cd temp
$ mkdir hello
$ mkdir world
$ clear 
$ ls

Grab & drag right-hand Console window edge to resize window width

Expected:

Folders' colored background should only extend to the end of the folder name:

Actual:

Lines with folders that are last item on line extend folder background coloring to right hand end of line:

See the following for an example of where it goes very wrong:

And it gets worse when lines wrap!

References

Thanks to @jmorrill for reporting here: https://twitter.com/jmorrill/status/915982968094580736

The text was updated successfully, but these errors were encountered:

zadjii-msft · 2017-10-06T17:08:10Z

So this is basically because we don't know the difference between a space character that was purposefully emitted and just an empty cell in the buffer.

When we resize, we optimize things a little bit by just filling the rest of the row with the last color we saw (as we resize). This causes the rest of the row to fill up with the colors of the last character.

I can make it a bit better, but it will clear out any colored spaces at the end of the row:

See how the last two spaces of the white column were reset.

Might be an acceptable hit considering that resizing is already an AWFUL perf path.

(opened msft:14115086 to track)

jmorrill · 2017-10-06T17:12:53Z

Thanks for looking into this guys.

IMO your suggestion of "I can make it a bit better, but it will clear out any colored spaces at the end of the row" looks more acceptable to me than the current behavior.

Curious what others think.

Windows Version: Microsoft Windows [Version 10.0.16299.15]

bitcrazed · 2017-10-06T17:56:34Z

FWIW, this isn't a problem that's unique to Console - Hyper also struggles to handle this scenario:

jmorrill · 2017-10-06T18:03:03Z

I've also seen this issue in hyper (and VS Code terminal window), but assumed it was something common to all of them and "lower level" in Windows.

zadjii-msft · 2017-10-06T19:54:45Z

That's correct, Hyper and others all query an underlying conhost, so if we've got it wrong then it will be wrong for everyone.

parkovski · 2017-10-20T19:56:55Z

I have a similar (same?) issue with Vim/WSL with the termguicolors option set.
Before resize:

After resize:

Expected (iTerm):

dra27 · 2018-01-08T11:08:55Z

I'm sure it's all part of the same thing - this also affects underlined text.

encladeus · 2019-09-05T18:41:01Z

Bump: As of Terminal 0.4.2382.0 this is still an issue. Using WSL Ubuntu shell I can recreate this many ways, but one easy way is to execute the following command:

Then resize the window and the line is repainted incorrectly:

…. I was worng. My theory was "fuck perf, let's do it right, and figure out perf later". It didn't work. This wraps lines super weird, probably because I'm copying the whole line to the right side of the row, which is then starting to mark it as wrapped. Also like the test doesn't even pass.

bunch of todos. It also totally takes care of #12567 as well

## THE WHITE WHALE This is a fairly naive fix for this bug. It's not terribly performant, but neither is resize in the first place. When the buffer gets resized, typically we only copy the text up to the `MeasureRight` point, the last printable char in the row. Then we'd just use the last char's attributes to fill the remainder of the row. Instead, this PR changes how reflow behaves when it gets to the end of the row. After we finish copying text, then manually walk through the attributes at the end of the row, and copy them over. This ensures that cells that just have a colored space in them get copied into the new buffer as well, and we don't just blat the last character's attributes into the rest of the row. We'll do a similar thing once we get to the last printable char in the buffer, copying the remaining attributes. This could DEFINITELY be more performant. I think this current implementation walks the attrs _on every cell_, then appends the new attrs to the new ATTR_ROW. That could be optimized by just using the actual iterator. The copy after the last printable char bit is also especially bad in this regard. That could likely be a blind copy - I just wanted to get this into the world. Finally, we now copy the final attributes to the correct buffer: the new one. We used to copy them to the _old_ buffer, which we were about to destroy. ## Validation I'll add more gifs in the morning, not enough time to finish spinning a release Terminal build with this tonight. Closes #32 🎉🎉🎉🎉🎉🎉🎉🎉🎉 Closes #12567

## THE WHITE WHALE This is a fairly naive fix for this bug. It's not terribly performant, but neither is resize in the first place. When the buffer gets resized, typically we only copy the text up to the `MeasureRight` point, the last printable char in the row. Then we'd just use the last char's attributes to fill the remainder of the row. Instead, this PR changes how reflow behaves when it gets to the end of the row. After we finish copying text, then manually walk through the attributes at the end of the row, and copy them over. This ensures that cells that just have a colored space in them get copied into the new buffer as well, and we don't just blat the last character's attributes into the rest of the row. We'll do a similar thing once we get to the last printable char in the buffer, copying the remaining attributes. This could DEFINITELY be more performant. I think this current implementation walks the attrs _on every cell_, then appends the new attrs to the new ATTR_ROW. That could be optimized by just using the actual iterator. The copy after the last printable char bit is also especially bad in this regard. That could likely be a blind copy - I just wanted to get this into the world. Finally, we now copy the final attributes to the correct buffer: the new one. We used to copy them to the _old_ buffer, which we were about to destroy. ## Validation I'll add more gifs in the morning, not enough time to finish spinning a release Terminal build with this tonight. Closes #32 🎉🎉🎉🎉🎉🎉🎉🎉🎉 Closes #12567 (cherry picked from commit 855e136)

ghost · 2022-04-19T19:56:50Z

🎉This issue was addressed in #12637, which has now been successfully released as Windows Terminal v1.12.1098.:tada:

Handy links:

ghost · 2022-04-19T19:59:05Z

🎉This issue was addressed in #12637, which has now been successfully released as Windows Terminal Preview v1.13.1098.:tada:

Handy links:

## THE WHITE WHALE This is a fairly naive fix for this bug. It's not terribly performant, but neither is resize in the first place. When the buffer gets resized, typically we only copy the text up to the `MeasureRight` point, the last printable char in the row. Then we'd just use the last char's attributes to fill the remainder of the row. Instead, this PR changes how reflow behaves when it gets to the end of the row. After we finish copying text, then manually walk through the attributes at the end of the row, and copy them over. This ensures that cells that just have a colored space in them get copied into the new buffer as well, and we don't just blat the last character's attributes into the rest of the row. We'll do a similar thing once we get to the last printable char in the buffer, copying the remaining attributes. This could DEFINITELY be more performant. I think this current implementation walks the attrs _on every cell_, then appends the new attrs to the new ATTR_ROW. That could be optimized by just using the actual iterator. The copy after the last printable char bit is also especially bad in this regard. That could likely be a blind copy - I just wanted to get this into the world. Finally, we now copy the final attributes to the correct buffer: the new one. We used to copy them to the _old_ buffer, which we were about to destroy. ## Validation I'll add more gifs in the morning, not enough time to finish spinning a release Terminal build with this tonight. Closes #32 🎉🎉🎉🎉🎉🎉🎉🎉🎉 Closes #12567 (cherry picked from commit 855e136)

bitcrazed assigned zadjii-msft Oct 6, 2017

bitcrazed added Work-Item It's being tracked by an actual work item internally. (to be removed soon) Product-Conhost For issues in the Console codebase labels Oct 6, 2017

zadjii-msft mentioned this issue Oct 27, 2017

ANSI/VT bleeds through empty spaces on right when resizing console with wrap on resize enabled microsoft/WSL#2607

Closed

bitcrazed mentioned this issue Feb 16, 2018

ANSI/VT bleeds through empty spaces on right when resizing console with wrap on resize enabled #75

Closed

DHowett-MSFT mentioned this issue Feb 6, 2019

ConPTY fills background incorrectly when resized #294

Closed

miniksa added the Mass-Chaos label May 17, 2019

ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019

miniksa removed the Mass-Chaos label May 17, 2019

miniksa added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. labels May 29, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 29, 2019

DHowett-MSFT mentioned this issue Oct 8, 2019

Error in WSL font highlight after resizing window #3112

Closed

This was referenced Dec 3, 2019

Color-coded dirs smear across screen when resizing window #3816

Closed

Weird blue selection after closing neovim (WSL) #3848

Closed

zadjii-msft mentioned this issue Jan 19, 2020

Teminal doesn't preserve colored blocks of characters. #4300

Closed

zadjii-msft added this to the Console Backlog milestone Jan 19, 2020

zadjii-msft removed their assignment Jan 19, 2020

zadjii-msft added the Priority-3 A description (P3) label Jan 19, 2020

zadjii-msft modified the milestones: Console Backlog, 21H1 Jan 19, 2020

zadjii-msft mentioned this issue Dec 6, 2021

Resolve longstanding issues with conhost's MeasureRight #2089

Closed

DHowett mentioned this issue Dec 13, 2021

background colors extend to end of line when window is resized #11936

Closed

t5mat added a commit to t5mat/turnbinds that referenced this issue Dec 21, 2021

Workaround for microsoft/terminal#32

cbb20f7

t5mat added a commit to t5mat/turnbinds that referenced this issue Dec 21, 2021

Workaround for microsoft/terminal#32

047ad7f

zadjii-msft modified the milestones: Windows vNext, 22H2 Jan 4, 2022

zadjii-msft mentioned this issue Mar 2, 2022

Full-screen COLOR command no longer works right when resizing conhost and Terminal #12567

Closed

zadjii-msft added a commit that referenced this issue Mar 2, 2022

I think this is a fix for #32

1f6210d

bunch of todos. It also totally takes care of #12567 as well

LuanVSO added a commit to LuanVSO/pwsh-profile that referenced this issue Mar 5, 2022

add workaround for microsoft/terminal#32

8753c32

LuanVSO added a commit to LuanVSO/pwsh-profile that referenced this issue Mar 5, 2022

add workaround for microsoft/terminal#32

5561087

zadjii-msft mentioned this issue Mar 7, 2022

Manually copy trailing attributes on a resize #12637

Merged

ghost added the In-PR This issue has a related PR label Mar 7, 2022

zadjii-msft modified the milestones: 22H2, Terminal v1.14 Mar 7, 2022

gskt17 mentioned this issue Mar 18, 2022

"Colour wrapping" BurntSushi/ripgrep#2161

Closed

ghost closed this as completed in #12637 Mar 21, 2022

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 21, 2022

This was referenced Mar 31, 2022

Color goes default while printring tree command #12797

Closed

Certain SGR attributes are not preserved after a resize sequence #2540

Closed

LuanVSO added a commit to LuanVSO/pwsh-profile that referenced this issue Apr 19, 2022

remove workaround for microsoft/terminal#32

572f0dd

Zeek05 mentioned this issue Jun 5, 2022

Unexpected ANSI sequence behavior in cmd.exe #13231

Closed

brice-automatizit mentioned this issue Jul 10, 2023

Write-Host with background colour fills the entire line with background colour after multiple execution PowerShell/PowerShell#19914

Open

5 tasks

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Console doesn't handle colored regions when reflowed #32

Console doesn't handle colored regions when reflowed #32

bitcrazed commented Oct 6, 2017 •

edited

Loading

zadjii-msft commented Oct 6, 2017 •

edited

Loading

jmorrill commented Oct 6, 2017 •

edited

Loading

bitcrazed commented Oct 6, 2017

jmorrill commented Oct 6, 2017

zadjii-msft commented Oct 6, 2017

parkovski commented Oct 20, 2017

dra27 commented Jan 8, 2018

encladeus commented Sep 5, 2019

ghost commented Apr 19, 2022

ghost commented Apr 19, 2022

Console doesn't handle colored regions when reflowed #32

Console doesn't handle colored regions when reflowed #32

Comments

bitcrazed commented Oct 6, 2017 • edited Loading

Expected:

Actual:

References

zadjii-msft commented Oct 6, 2017 • edited Loading

jmorrill commented Oct 6, 2017 • edited Loading

bitcrazed commented Oct 6, 2017

jmorrill commented Oct 6, 2017

zadjii-msft commented Oct 6, 2017

parkovski commented Oct 20, 2017

dra27 commented Jan 8, 2018

encladeus commented Sep 5, 2019

ghost commented Apr 19, 2022

ghost commented Apr 19, 2022

bitcrazed commented Oct 6, 2017 •

edited

Loading

zadjii-msft commented Oct 6, 2017 •

edited

Loading

jmorrill commented Oct 6, 2017 •

edited

Loading