Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open new tab next to the current one #12955

Closed
liuerfire opened this issue Apr 21, 2022 · 4 comments · Fixed by #13421
Closed

Open new tab next to the current one #12955

liuerfire opened this issue Apr 21, 2022 · 4 comments · Fixed by #13421
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@liuerfire
Copy link

Description of the new feature/enhancement

Create a new tab to the be placed next the current tab instead of at the end.

Proposed technical implementation details (optional)

the Kitty terminal: https://sw.kovidgoyal.net/kitty/launch/#cmdoption-launch-location

Konsole:
image
@liuerfire liuerfire added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 21, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 21, 2022
@zadjii-msft
Copy link
Member

  • Reasonable, well-defined behavior
  • simple enough setting design
  • existing precedent in other terminals

I don't think I could ask for a better feature request 😄

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. good first issue This is a fix that might be easier for someone to do as a first contribution labels Apr 21, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 21, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 21, 2022
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 21, 2022
@BenConstable9
Copy link
Contributor

@zadjii-msft can I try and tackle this one?

@zadjii-msft
Copy link
Member

@BenConstable9 Go right ahead!

@serd2011 serd2011 mentioned this issue Jul 2, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 2, 2022
@ghost ghost closed this as completed in #13421 Jul 8, 2022
ghost pushed a commit that referenced this issue Jul 8, 2022
@serd2011
Add ability to select where new tab will appear (#13421)
55dd4af 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Adds ability to select where new tab will appear: at the end or after currently selected tab.

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #12955 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
PR adds setting "NewTabPosition" in global appearances with dropdown list and uses it then creating new tabs. This setting does not affect settings tab position (should it?).
There should also be a documentation update, I'm just waiting to see if this change even acceptable.
<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 8, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13421, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Jan 16, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add ability to select where new tab will appear serd2011/terminal
3 participants
@liuerfire @BenConstable9 @zadjii-msft