Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Open JSON file easier to discover #13225

Closed
a5hk opened this issue Jun 4, 2022 · 9 comments · Fixed by #13265
Closed

Make Open JSON file easier to discover #13225

a5hk opened this issue Jun 4, 2022 · 9 comments · Fixed by #13265
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.15

Comments

@a5hk
Copy link

a5hk commented Jun 4, 2022

Description of the new feature/enhancement

Once in a while I want to change something in the JSON settings file, and many times I spend several minutes to find that option. It mostly happens when the window is maximized. The button is too far away from the rest of the options.

image

Proposed technical implementation details (optional)

I think it can be added to this menu:

image
@a5hk a5hk added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 4, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 4, 2022
@237dmitry
Copy link

As a variant you can create environment variable or shell variable. I create in pwsh's profile $WT_SETTINGS var:

Screenshot 2022-06-04 140059

And edit file in your favorite editor, for example:

> notepad $WT_SETTINGS

@DHowett
Copy link
Member

DHowett commented Jun 4, 2022

You can also get to the JSON file by holding down Shift and clicking on the "Settings" menu item, my pressing Ctrl+Shift+,, or by opening the command palette with Ctrl+Shift+P and searching for JSON.

Are any of those sufficient?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 4, 2022
@a5hk
Copy link
Author

a5hk commented Jun 4, 2022

Are any of those sufficient?

I first learned about the settings file through UI. Now that I know a JSON settings file exists, the last option is sufficient for me, I won't forget that one. However, the command is "Open settings file", searching JSON didn't work for me. I have version 1.12.10982.0 installed.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 4, 2022
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jun 6, 2022
@zadjii-msft
Copy link
Member

opening the command palette with Ctrl+Shift+P and searching for JSON.

terminal/src/cascadia/TerminalSettingsModel/defaults.json

Line 293 in ed27737

{ "command": { "action": "openSettings", "target": "settingsFile" }, "keys": "ctrl+shift+," },

image

Looks like that string doesn't actually have "JSON" in it - should it?

(part of #1571 would also cover the ability to add your own actions to the new tab menu, so you could feel free to add a "Open JSON" action that way)

@zadjii-msft zadjii-msft added Needs-Discussion Something that requires a team discussion before we can proceed and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jun 6, 2022
@a5hk
Copy link
Author

a5hk commented Jun 6, 2022

Looks like that string doesn't actually have "JSON" in it - should it?

IMO having JSON in that string would make the command more discoverable, at least for VS Code users:

image

@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Jun 6, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 6, 2022
@zadjii-msft
Copy link
Member

Discussion:

  • Yes we should change the string to "Open settings file (JSON)" with json locked
  • We should also probably add a tooltip to the New Tab dropdown entry as well

@zadjii-msft zadjii-msft added this to the Terminal v1.15 milestone Jun 6, 2022
@vadimkantorov
Copy link

Discussion:

  • Yes we should change the string to "Open settings file (JSON)" with json locked
  • We should also probably add a tooltip to the New Tab dropdown entry as well

Related: #10354, sometimes "settings file" is clearer, sometimes "json", but consistency is even more important IMO

@zadjii-msft zadjii-msft mentioned this issue Jun 10, 2022
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Jun 10, 2022
@ghost ghost closed this as completed in #13265 Jun 10, 2022
ghost pushed a commit that referenced this issue Jun 10, 2022
@zadjii-msft
Add "JSON" to the "Open settings file" command names (#13265)
dc8183a 
![image](https://user-images.githubusercontent.com/18356694/173090336-3512ee36-ae8b-41d5-8823-09cb1354c7ef.png)

* [x] Closes #13225
@ghost ghost removed the In-PR This issue has a related PR label Jun 10, 2022
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jun 10, 2022
DHowett pushed a commit that referenced this issue Jun 30, 2022
@zadjii-msft @DHowett
Add "JSON" to the "Open settings file" command names (#13265)
ddf46f2 
![image](https://user-images.githubusercontent.com/18356694/173090336-3512ee36-ae8b-41d5-8823-09cb1354c7ef.png)

* [x] Closes #13225

(cherry picked from commit dc8183a)
Service-Card-Id: 83524146
Service-Version: 1.14
@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13265, which has now been successfully released as Windows Terminal v1.14.186.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13265, which has now been successfully released as Windows Terminal Preview v1.15.186.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.15
Development

Successfully merging a pull request may close this issue.

Add "JSON" to the "Open settings file" command names microsoft/terminal
5 participants
@DHowett @vadimkantorov @a5hk @zadjii-msft @237dmitry