Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]: Screen Reader is not announcing name for 'Tab Title' edit field inside Startup page. #13827

Closed
ghost opened this issue Aug 23, 2022 · 2 comments · Fixed by #14178
Closed

[Settings]: Screen Reader is not announcing name for 'Tab Title' edit field inside Startup page. #13827

ghost opened this issue Aug 23, 2022 · 2 comments · Fixed by #14178
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-Mobility Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.17

Comments

@ghost
Copy link

ghost commented Aug 23, 2022 •
edited by ghost

Windows Terminal version

1.15.2003.0

Windows build number

10.0.25179.1000

Other Software

Test Environment:
OS: Window 11 22H2 OS Build 25179.1000
App: Windows Terminal Preview
AT: Narrator

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Narrator AT.
  3. Inside Settings> Startup page, Expand Tab title control then navigate to Edit field control and observe the issue.

User Experience:
People with Visual impairments like Screen Reader will be impacted here as well as they might not be able to figure out edit field purpose.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
Edit Tab Title.zip

Expected Behavior

Screen Reader should announce 'Edit Tab Title' for 'Tab Title' edit field inside Startup page.

Actual Behavior

Screen Reader is only announcing 'Edit' for 'Tab Title' edit field inside Startup page.

Note Issue: Same issue repro with Edit field which present inside 'Settings> Startup> Word delimiters' and 'Settings> Command Prompt> Name'.

Observation:
Issue repro with JAWS and NVDA Screen Reader.
Screen Reader users might figure out name by its group control name.
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yMAS Accessibility tracking Disability-Mobility Accessibility tracking Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 23, 2022
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Aug 23, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Aug 23, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 added A11yWCAG Accessibility tracking and removed A11yMAS Accessibility tracking labels Aug 30, 2022
@carlos-zamora carlos-zamora removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 10, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 10, 2022
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Oct 10, 2022
@carlos-zamora carlos-zamora mentioned this issue Oct 10, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 10, 2022
@ghost ghost closed this as completed in #14178 Nov 4, 2022
@ghost ghost removed the In-PR This issue has a related PR label Nov 4, 2022
ghost pushed a commit that referenced this issue Nov 4, 2022
@carlos-zamora
Apply AutoProps to TextBox settings in SUI (#14178)
62b34cf 
We already were setting the automation properties on the expander, however, we were not setting it on the content when an expander was present. This change applies the automation properties to both the expander and the child content (i.e. TextBox).

Closes #13827
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 4, 2022
DHowett pushed a commit that referenced this issue Dec 12, 2022
@carlos-zamora @DHowett
Apply AutoProps to TextBox settings in SUI (#14178)
d19b962 
We already were setting the automation properties on the expander, however, we were not setting it on the content when an expander was present. This change applies the automation properties to both the expander and the child content (i.e. TextBox).

Closes #13827

(cherry picked from commit 62b34cf)
Service-Card-Id: 87207144
Service-Version: 1.16
DHowett pushed a commit that referenced this issue Dec 12, 2022
@carlos-zamora @DHowett
Apply AutoProps to TextBox settings in SUI (#14178)
0f1ce90 
We already were setting the automation properties on the expander, however, we were not setting it on the content when an expander was present. This change applies the automation properties to both the expander and the child content (i.e. TextBox).

Closes #13827

(cherry picked from commit 62b34cf)
Service-Card-Id: 87207143
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14178, which has now been successfully released as Windows Terminal v1.15.3465.0 and v1.15.3466.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14178, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-Mobility Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Apply AutoProps to TextBox settings in SUI microsoft/terminal
3 participants
@carlos-zamora @zadjii-msft @Priyanka-Chauhan123