Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAWS] Search results read "results found" instead of something useful #14153

Open
carlos-zamora opened this issue Oct 6, 2022 · 2 comments
Open
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

Windows Terminal version

1.16.2642

Windows build number

No response

Other Software

JAWS (though this probably repros with any screen reader)

Steps to reproduce

  1. generate text (i.e. ls)
  2. open search dialog (ctrl+shift+f)
  3. search for something (i.e. text) NOTE: make sure there are results!

Expected Behavior

the line of text should be read (i.e. this is example text where "text" is selected)

This gives context to the user

Actual Behavior

reads "results available"

Most likely caused by #12301

Other feedback

  • "no results found" is good!
  • "findMatch" should work the exact same way
  • when we loop around the buffer, we should say "back to top/bottom"
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. labels Oct 6, 2022
@carlos-zamora
Copy link
Member Author

Throwing this in next milestone. I don't think we'll have time to fix this for this coming release, but this is a decent dissatisfaction for screen reader users (I mean, find is basically useless tbh).

Feel free to change if you disagree.

@carlos-zamora carlos-zamora added this to the Terminal v1.18 milestone Oct 6, 2022
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 6, 2022
@zadjii-msft
Copy link
Member

I'm tossing this back to the backlog. Though, now we could actually announce how many results there were, so that's cool

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.19, Backlog Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants