Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings Page #1423

Closed
ArtexJay opened this issue Jun 22, 2019 · 5 comments
Closed

Add Settings Page #1423

ArtexJay opened this issue Jun 22, 2019 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ArtexJay
Copy link

Summary of the new feature/enhancement

Users who do not want to tinker in the js file to get the desired settings would have a better time in the settings enabling or disabling certain features. Or changing the font much more easily.

Proposed technical implementation details (optional)

When clicking on the settings option it should open up a page where one would be able to easily change their settings as they please via a GUI and not through a JS text editor.

@ArtexJay ArtexJay added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 22, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 22, 2019
@imjasonmiller
Copy link

Users who do not want to tinker in the js file ...

Aren't most active users of the terminal familiar with .json files? It makes it much easier to share settings with other users and devices. They briefly touched on this during this talk and mentioned that it was a big ask from the community.
I can imagine that the current implementation might allow developers to move faster as well.

@josh-degraw
Copy link

@imjasonmiller I personally don't mind that the config is in json, for me the issue is knowing what can go where. The schema documentation page took me a while to find and was less clear than it could be, and there were things I'd seen other people try with the terminal but couldn't find out how to do it.

What I would love is basically just a wrapper on top of the config file, in a similar way as how VsCode handles configuration. You can use the GUI if you want, or if you prefer or need more advanced config you can open the json file.

Another annoyance for me was that when I hit settings it launched visual studio, and I thought my system was trying to relaunch that after rebooting, so I hit settings again a couple of times and it launched like 5 instances of Visual Studio before it actually opened.

I'm aware that's because VS is the default for that on my machine for some reason, which I will change, but it was still a confusion/hassle.

@csm10495
Copy link

I'm going to agree that a settings GUI would be nicer than a json file. I guess if someone really wants to mess with the raw file, they still could. A GUI works better for me since its easier to read and layout than a raw file. We can also have descriptions for the different options.

... reminds me of the similar changes that were made to VS Code to have a settings GUI instead of just a raw json.

@cinnamon-msft cinnamon-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@cinnamon-msft
Copy link
Contributor

#1564

@Nyameliaaaa
Copy link

I believe that users who even use the terminal can tinker in raw json, so this is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants