Lost new line character when using ReadFile

[confusedsushi]

Windows Terminal version

1.18.2822.0

Windows build number

10.0.22631.2361

Other Software

The problem was first noted in some other console application which is using ReadFile to read from the console. The problem was stripped down to a minimal program

#include <assert.h>
#include <windows.h>

int __cdecl main() {
  char buf[2];
  DWORD read;

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 2, &read, NULL);
  assert(read == 2);
  assert(buf[0] == '\r');
  assert(buf[1] == '\n');

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL);
  assert(read == 1);
  assert(buf[0] == '\r');

  ReadFile(GetStdHandle(STD_INPUT_HANDLE), buf, 1, &read, NULL);
  assert(read == 1);
  assert(buf[0] == '\n');
}

It seems the unexpected behavior first occurred with #14745.

Steps to reproduce

Compile the program using your favorite C compiler and run it. Hit <ENTER> until the example exits.

Expected Behavior

In the good case you have to hit <ENTER> twice and the program exits gracefully.

Actual Behavior

In the bad case you have to hit <ENTER> three times and the last assert fires an error.

[codesculpture]

Hey, is this being landed in release ? If yes, in which version

[DHowett]

This is staged for the next 1.18 servicing release! Sorry for the delay.