Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split pane on !default profile opens new pane in default profile #16482

Closed
wmmihaa opened this issue Dec 18, 2023 · 2 comments
Closed

Split pane on !default profile opens new pane in default profile #16482

wmmihaa opened this issue Dec 18, 2023 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@wmmihaa
Copy link

wmmihaa commented Dec 18, 2023

Windows Terminal version

1.18.3181.0

Windows build number

MS Windows 23H2(OS Build 22635.2850)

Other Software

N/A

Steps to reproduce

  1. Open terminal
  2. Open a new none default profile (in my case Ubuntu)
  3. Split pane using short command (in my case alt + shift + plus)

Result: a new pane opens in the default profile (in my case Power Shell)

If right-clicking the active tab and select "Split pane" the new pane opens for the same profile (as expected)

Expected Behavior

When splitting a pane I'd expect the new pane to open in the same profile. If right-clicking the active tab and select "Split pane" the new pane opens for the same profile (as expected)

Actual Behavior

All new panes in the same tab should open in the same profile
@wmmihaa wmmihaa added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 18, 2023
@github-actions GitHub Actions
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@wmmihaa
Copy link
Author

wmmihaa commented Dec 22, 2023

Duplicate

@wmmihaa wmmihaa closed this as completed Dec 22, 2023
This was referenced Jan 5, 2024
Merged
Merged
Merged
Merged
denelon pushed a commit to microsoft/winget-cli that referenced this issue Jan 8, 2024
@craigloewen-msft
Create similarissues.yml (#4035)
7310865 
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] -->

- [X] I have signed the [Contributor License
Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs).
- [ ] This pull request is related to an issue.

-----

<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request

Creates a new GitHub action that makes a bot that will automatically
comment on new issues letting them know about similarly titled issues
using AI. Comments will look like this:


microsoft/terminal#16482 (comment)

The advantage is that users will be able to find related issues faster,
and be able to resolve themselves quicker, with you as a maintainer
having to close out less issues.

<!-- Provide a more detailed description of the PR, other things fixed
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

The bot code is [open sourced
here](https://github.com/craigloewen-msft/GitGudSimilarIssues).

<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

Validated on other repos. You can manually validate queries like so: 

https://gitgudissues.azurewebsites.net/api/getsimilarissues/microsoft/powertoys/record%20gifs%20in%20file%20explorer


###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4035)
@craigloewen-msft craigloewen-msft mentioned this issue Jan 9, 2024
Merged
@github-actions github-actions bot mentioned this issue May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wmmihaa