Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21] Changing a font axis/feature value does not update the preview #17171

Closed
DHowett opened this issue May 1, 2024 · 0 comments · Fixed by #17173
Closed

[1.21] Changing a font axis/feature value does not update the preview #17171

DHowett opened this issue May 1, 2024 · 0 comments · Fixed by #17173
Assignees
@lhecker
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@DHowett
Copy link
Member

DHowett commented May 1, 2024

I need to save/switch pages/change a different setting
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 1, 2024
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI labels May 1, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.21 milestone May 1, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Tag-Fix Doesn't match tag requirements labels May 1, 2024
@lhecker lhecker mentioned this issue May 1, 2024
Merged
@lhecker lhecker added the In-PR This issue has a related PR label May 1, 2024
DHowett pushed a commit that referenced this issue May 2, 2024
@lhecker
Fix font axis/feature SUI issues (#17173)
475b387 
Something something code changes, fixes issue. Events need throwing,
some events don't need throwing, some events need throttling to
not overwhelm the flurble function within the gumbies component.
This is all boilerplate and it works now.

Closes #17171
Closes #17172

## Validation Steps Performed
* Resetting the font axis/feature expander keeps
  the add new button flyout sorted ✅
* Changing a font axis/feature value updates the preview ✅
* After changing the font, features/axes can still be edited ✅
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Fix font axis/feature SUI issues microsoft/terminal
3 participants
@DHowett @lhecker @carlos-zamora