Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The suggestions UI is populated with trailing spaces when useCommandline: true #17241

Closed
Tracked by #15845
zadjii-msft opened this issue May 10, 2024 · 0 comments · Fixed by #17245
Closed
Tracked by #15845

The suggestions UI is populated with trailing spaces when useCommandline: true #17241

zadjii-msft opened this issue May 10, 2024 · 0 comments · Fixed by #17245
Labels
In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@zadjii-msft
Copy link
Member

  1. do a shell integration https://github.com/MicrosoftDocs/terminal/blob/main/TerminalDocs/tutorials/shell-integration.md
  2. run commands
  3. (maybe) type some chars, then hit esc to dismiss the prompt.
  4. open sxnui with 
         {
         "command":
         {
             "action": "showSuggestions",
             "source": "commandHistory",
             "useCommandline": true
         },
         "id": "User.showSuggestions.807E15EE",
         "keys": "ctrl+shift+h"
     },
  5. sxnui is pre-loaded with spaces and
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 10, 2024
This was referenced May 10, 2024
Open
Merged
@zadjii-msft zadjii-msft added the In-PR This issue has a related PR label May 13, 2024
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@zadjii-msft
Clean up command history context passed to suggestions UI (#17245)
bf8a647 
This is fallout from #16937. 

* Typing a command then backspacing the chars then asking for
suggestions would think the current commandline ended with spaces,
making filtering very hard.
* The currently typed command would _also_ appear in the command
history, which isn't useful.

I actually did TDD for this and wrote the test first, then confirmed
again running through the build script, I wasn't hitting any of the
earlier issues.

Closes #17241
Closes #17243
DHowett pushed a commit that referenced this issue Jun 7, 2024
@zadjii-msft @DHowett
Clean up command history context passed to suggestions UI (#17245)
8038dc6 
This is fallout from #16937.

* Typing a command then backspacing the chars then asking for
suggestions would think the current commandline ended with spaces,
making filtering very hard.
* The currently typed command would _also_ appear in the command
history, which isn't useful.

I actually did TDD for this and wrote the test first, then confirmed
again running through the build script, I wasn't hitting any of the
earlier issues.

Closes #17241
Closes #17243

(cherry picked from commit bf8a647)
Service-Card-Id: 92638413
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up command history context passed to suggestions UI microsoft/terminal
1 participant
@zadjii-msft