Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows key doesn't work when assigning key actions #17437

Open
matthewclso opened this issue Jun 17, 2024 · 5 comments
Open

Windows key doesn't work when assigning key actions #17437

matthewclso opened this issue Jun 17, 2024 · 5 comments
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements
Milestone

Comments

@matthewclso
Copy link

matthewclso commented Jun 17, 2024

Windows Terminal version

1.20.11381.0

Windows build number

10.0.22621.3737

Other Software

No response

Steps to reproduce

Go to settings --> actions --> any action and try to set the key combination. Any combination that involves the windows key is not recognized. This is new with a recent version of terminal.

Expected Behavior

Windows key should be allowed in actions key combinations.

Actual Behavior

The key command does not change. It only changes if the windows key is not involved in the input.

@matthewclso matthewclso added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 17, 2024
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-Settings UI Anything specific to the SUI and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 22, 2024
@zadjii-msft zadjii-msft added this to the Backlog milestone Jun 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 22, 2024
@j4james
Copy link
Collaborator

j4james commented Jun 23, 2024

My understanding was that this was by design, since the Windows key is meant to be reserved for OS usage. See #4329 (comment). But perhaps that policy has changed.

@matthewclso
Copy link
Author

That makes sense, however I don't know why the feature was removed in a recent release. It had been working for quite a long time, so I don't believe it's a technical limitation.

@j4james
Copy link
Collaborator

j4james commented Jun 23, 2024

@matthewclso Sorry, I was mistaken. The policy obviously was changed at some point, and support for the Win key was added in PR #9783. I just checked the version I have installed (1.21.1272.0), and it definitely works for me. Is it possible that you're just trying to use a key combination that is already in use by the OS, or some other apps that's hijacking hotkeys? For example, try an obscure combination like Win+Ctrl+Shift+X.

@matthewclso
Copy link
Author

Ah, Win+Ctrl+Shift+x does work! But my old combination Win+Ctrl+t doesn't work. Oddly enough, Win+Ctrl+b does work. A few other combinations involving the windows key, even if not paired to a system command, don't work either - might the restrictions for certain key combinations have changed recently?

@j4james
Copy link
Collaborator

j4james commented Jun 23, 2024

might the restrictions for certain key combinations have changed recently?

Yeah, I was thinking the same thing. Possibly an OS upgrade or another app that you have installed, e.g. Microsoft PowerToys? I've just tried your key combination (Win+Ctrl+t) and it works for me, but I'm on Windows 10. I've also tried installing the same version of Windows Terminal as you (1.20.11381.0) and it works there too, so I don't think it's related to the terminal version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements
Projects
None yet
Development

No branches or pull requests

3 participants