Add support for the win key in keybindings

[zadjii-msft]

Summary of the Pull Request

Does what it says on the can. People can now use win in a keybinding to
indicate that the chord needs win.

References

• Done for Feature request: hot key drop down ala quake/guake/tilda #653
• See also [MEGATHREAD] Quake Mode & Global Summon #8888

PR Checklist

• Closes Consider adding support for win in key bindings? #3184
• I work here
• Tests added/passed
• Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

For the record, I hate this. But it's great for quake mode, so meh. There's
shockingly more win keys claimed then you think - many more than the shortcut
guide even shows.

• win+b: Focus the tray?
• win+t: Focus the taskbar
• win+p: Project...
• win+c: The powertoys color picker
• win+v: cloud clipboard

So the list of valid combos is vanishingly small. It's all about that win+~

Validation Steps Performed

Bound

        { "keys": [ "win+`" ], "command": "commandPalette" },

and yea, it works as expected

[github-actions]

Misspellings found, please review:

• valuse

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"aef aspnet boostorg BSODs Cac COINIT dahall DEFAPP DEFCON fde fea fmtlib HPCON isocpp mintty msvcrtd NVDA pinam QOL remoting Unk unte vcrt what3words xamarin "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect/b310b1cffc5df62f652ab1781d282ccfac3bb050.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling/expect";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"cac coinit defapp hpcon MSVCRTD Remoting unk valuse "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

• ... misspelled, then please correct them instead of using the command.
• ... names, please add them to .github/actions/spelling/dictionary/names.txt.
• ... APIs, you can add them to a file in .github/actions/spelling/dictionary/.
• ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
• ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the .github/actions/spelling/excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

[DHowett]

it actually works??? this is great

[carlos-zamora]

I'll let you/Michael figure out the regex thing. But don't forget to update the docs plz. We probably want some kind of warning in the docs too.

[zadjii-msft]

TODO:

• ConvertVKModifiers needs win too!
• Will this affect Do not dismiss selection if the Windows keys is pressed as a key-combination #9163?

[Don-Vito]

@zadjii-msft - will it affect #9163?

[zadjii-msft]

@zadjii-msft - will it affect #9163?

Oh, this, might. I'll take a look. Thanks!

[miniksa]

Marking req changes until the regex is sussed out.

[zadjii-msft]

Works in the flyout:

and cmdpal:

And it doesn't dismiss the selection ✔️ (or rather, win+shift+s still works the same)

[zadjii-msft]

dev/migrie/f/653-QUAKE-MODE is ready to send once this merges (QUAKE-MODE has some of this win key code that needs to get the updates from this branch).

[ghost]

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download