Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BeginResize a RAII thing #2162

Open
zadjii-msft opened this issue Jul 30, 2019 · 0 comments
Open

Make BeginResize a RAII thing #2162

zadjii-msft opened this issue Jul 30, 2019 · 0 comments
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Milestone
Engineering Impro...

Comments

@zadjii-msft
Copy link
Member

Uh, maybe this method should just return an RAII object that stops the resize when it is destroyed like what we envision good locks to do.

Originally posted by @miniksa in #2149
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 30, 2019
@zadjii-msft zadjii-msft mentioned this issue Jul 30, 2019
Merged
1 task
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase labels Jul 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 30, 2019
@zadjii-msft zadjii-msft added this to the Console Backlog milestone Jul 30, 2019
zadjii-msft added a commit that referenced this issue Jul 30, 2019
@zadjii-msft
Start trying to do a raii thing
316bb93 
  This looks super weird though. There's gotta be a better way (and there is Kevin)

  Related to #2162, #2149
@miniksa miniksa removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
2 participants
@miniksa @zadjii-msft