Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: PowerShell Core launched by Azure Cloud Shell bash has positioning issues #2267

Closed
AlanMcBee opened this issue Aug 5, 2019 · 2 comments · Fixed by #4652
Closed

Bug Report: PowerShell Core launched by Azure Cloud Shell bash has positioning issues #2267

AlanMcBee opened this issue Aug 5, 2019 · 2 comments · Fixed by #4652
Labels
Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@AlanMcBee
Copy link

Environment

Windows build number: 1903 OS build 18362.239
Windows Terminal version (if applicable): 0.3.2142.0

Any other software? N/A

Steps to reproduce

  1. Launch Azure Cloud Shell profile tab and connect/login to Azure
  2. Launch PowerShell Core with command: pwsh
  3. Execute any PowerShell Core commands

Expected behavior

Cursor position should continue to advance down the console as commands are entered and output is produced by cmdlets.

Actual behavior

Keyboard-entered input (cursor) is initially repositioned at row 0, column 0 regardless of where the prompt positions the cursor.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 5, 2019
@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Aug 5, 2019 •
edited by bitcrazed

This bug is two-fold.

  1. Windows Terminal usually had conhost sitting in between client processes and itself doing some basic VT translation for it. Powershell asks where the cursor is, and WT doesn't know to answer.
  2. Powershell seems to have this pathological need to know where the cursor is at all times, which makes it very frustrating to use everywhere but windows.

@AlanMcBee AlanMcBee mentioned this issue Aug 5, 2019
Closed
@DHowett-MSFT DHowett-MSFT added Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 5, 2019
@DHowett-MSFT DHowett-MSFT added the Help Wanted We encourage anyone to jump in on these. label Aug 5, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Aug 5, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 8, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 16, 2019
Closed
@DHowett-MSFT DHowett-MSFT added Mass-Chaos Temporary use to trigger the bot. and removed Mass-Chaos Temporary use to trigger the bot. labels Oct 22, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Nov 4, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Dec 8, 2019
Closed
@cconrado
Copy link

Yes this drives me crazy lol

DHowett-MSFT pushed a commit that referenced this issue Feb 20, 2020
@DHowett
Shim the Azure connection through a conhost to stop VT bleeding
f82565e 
This commit introduces a small console-subsystem application whose sole
job is to consume TerminalConnection.dll and hook it up to something
other than Terminal. It is 99% of the way to a generic solution.

I've introduced a stopgap in TerminalPage that makes sure we launch
TerminalAzBridge using ConptyConnection instead of AzureConnection.

As a bonus, this commit includes a class whose sole job it is to make
reading VT input off a console handle not terrible. It returns you a
string and dispatches window size change callbacks.

Fixes #2267.
Fixes #4589.
Related to #2266 (since pwsh needs better VT).
@DHowett-MSFT DHowett-MSFT mentioned this issue Feb 20, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 20, 2020
@ghost ghost removed the Help Wanted We encourage anyone to jump in on these. label Feb 20, 2020
DHowett-MSFT pushed a commit that referenced this issue Feb 21, 2020
@DHowett
Shim the AzureConn through a conhost to stop VT bleeding (#4652)
7d6738c 
This commit introduces a small console-subsystem application whose sole
job is to consume TerminalConnection.dll and hook it up to something
other than Terminal. It is 99% of the way to a generic solution.

I've introduced a stopgap in TerminalPage that makes sure we launch
TerminalAzBridge using ConptyConnection instead of AzureConnection.

As a bonus, this commit includes a class whose sole job it is to make
reading VT input off a console handle not terrible. It returns you a
string and dispatches window size change callbacks.

Fixes #2267.
Fixes #4589.
Related to #2266 (since pwsh needs better VT).
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 21, 2020
This was referenced Feb 24, 2020
Closed
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 11, 2020
Closed
@github-actions github-actions bot mentioned this issue May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-AzureShell Workitems pertaining to the Azure Cloud Shell connection. Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Shim the Azure connection through a conhost to stop VT bleeding microsoft/terminal
4 participants
@cconrado @DHowett-MSFT @AlanMcBee @cinnamon-msft