Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonClientIslandWindow -- titlebar doubleclick no longer minmaxes #2513

Closed
DHowett-MSFT opened this issue Aug 22, 2019 · 5 comments · Fixed by #3024
Closed

NonClientIslandWindow -- titlebar doubleclick no longer minmaxes #2513

DHowett-MSFT opened this issue Aug 22, 2019 · 5 comments · Fixed by #3024
Assignees
@DHowett-MSFT @zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1910

Comments

@DHowett-MSFT
Copy link
Contributor

Double-click the titlebar as of 0.3.2321; it does not min/max.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 22, 2019
@zadjii-msft
Copy link
Member

I broke this with #2438 almost certainly

@Ade-Joshe
Copy link

Mine works...

@DHowett-MSFT
Copy link
Contributor Author

Our open bugs generally refer to whatever's on the master branch, which is almost certainly ahead of the released version. 😄 We're tracking this to make sure the public release doesn't break.

@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 28, 2019
Closed
@DHowett-MSFT DHowett-MSFT pinned this issue Aug 28, 2019
@eyalroth
Copy link

I just installed the terminal from the store and that's the first bug I've noticed.

Windows Terminal (Preview)
Version: 0.4.2382.0

This was referenced Aug 28, 2019
Closed
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 12, 2019
Closed
29 tasks
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 21, 2019
Closed
@zadjii-msft zadjii-msft added this to the Terminal-1910 milestone Sep 24, 2019
@zadjii-msft zadjii-msft self-assigned this Sep 24, 2019
DHowett-MSFT pushed a commit that referenced this issue Oct 1, 2019
@DHowett
Simplify non-client hit testing in NCIslandWindow to fix doubleclick
9dca53a 
It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.

Fixes #2513
DHowett-MSFT pushed a commit that referenced this issue Oct 1, 2019
@DHowett
Simplify non-client hit testing in NCIslandWindow to fix doubleclick
45460be 
It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.

Fixes #2513
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 1, 2019
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 1, 2019
carlos-zamora pushed a commit that referenced this issue Oct 2, 2019
@DHowett @carlos-zamora
Simplify non-client hit testing in NCIslandWindow to fix doubleclick (#…
621d841 
…3024)

It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.

Fixes #2513
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 2, 2019
DHowett-MSFT pushed a commit that referenced this issue Oct 3, 2019
@DHowett
Simplify non-client hit testing in NCIslandWindow to fix doubleclick (#…
42e281d 
…3024)

It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.

Fixes #2513
@ghost
Copy link

ghost commented Oct 4, 2019

🎉This issue was addressed in #3024, which has now been successfully released as Windows Terminal Preview v0.5.2762.0.:tada:

Handy links:

@DHowett-MSFT DHowett-MSFT unpinned this issue Oct 4, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 4, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1910
Development

Successfully merging a pull request may close this issue.

Simplify non-client hit testing in NCIslandWindow to fix doubleclick microsoft/terminal
4 participants
@eyalroth @DHowett-MSFT @zadjii-msft @Ade-Joshe