Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Cursor Indicator does not move with cursor #3791

Closed
Migod11 opened this issue Dec 1, 2019 · 4 comments · Fixed by #4826
Closed

Text Cursor Indicator does not move with cursor #3791

Migod11 opened this issue Dec 1, 2019 · 4 comments · Fixed by #4826
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@Migod11
Copy link

Migod11 commented Dec 1, 2019

Environment

Windows build number: 10.019033.0
Windows Terminal version (if applicable): 0.7.3291.0

Any other software? -

Steps to reproduce

Turn text cursor indicator in windows settings, and start wt

Expected behavior

Text Cursor Indicator follows text cursor, works fine in Windows Console

Actual behavior

Text cursor is displayed, but does not follow cursor
Annotation 2019-12-01 085324
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 1, 2019
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Dec 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 2, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Dec 2, 2019
@DHowett-MSFT
Copy link
Contributor

Yeah, looks like we'll need to notify some input subsystem where the insertion point is. Thanks!

@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 2, 2019
@shanselman
Copy link
Member

Just checking in.
image

@DHowett-MSFT
Copy link
Contributor

Yep: this bug will be closed when we believe the issue to be fixed. 😄

@zadjii-msft zadjii-msft added the Area-Accessibility Issues related to accessibility label Mar 12, 2020
@carlos-zamora carlos-zamora self-assigned this Mar 12, 2020
@carlos-zamora carlos-zamora mentioned this issue Mar 17, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Mar 17, 2020
@ghost ghost closed this as completed in #4826 Mar 18, 2020
@ghost ghost removed the In-PR This issue has a related PR label Mar 18, 2020
ghost pushed a commit that referenced this issue Mar 18, 2020
@carlos-zamora
Fire UIA Events for Output and Cursor Movement (#4826)
eca0c6b 
## Summary of the Pull Request
This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen.

## References
Close #2447 - Signaling for new output and cursor
Close #3791 - fixed by signaling cursor changes

## Detailed Description of the Pull Request / Additional comments
- Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client.
- Fire TextChanged automation events when new content is output to the screen.

## Validation Steps Performed
Verified with NVDA [1]

## Narrator
Narrator works _better_, but is unable to detect new output consistently. There is no harm for narrator when this change goes in.

[1] #2447 (comment)
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 18, 2020
@carlos-zamora carlos-zamora mentioned this issue Mar 31, 2020
Merged
1 task
ghost pushed a commit that referenced this issue Apr 1, 2020
@carlos-zamora
Reduce CursorChanged Events for Accessibility (#5196)
f8227e6 
## Summary of the Pull Request
Reduce the number of times we dispatch a cursor changed event. We were firing it every time the renderer had to do anything related to the cursor. Unfortunately, blinking the cursor triggered this behavior. Now we just check if the position has changed.

## PR Checklist
* [X] Closes #5143


## Validation Steps Performed
Verified using Narrator
Also verified #3791 still works right
DHowett-MSFT pushed a commit that referenced this issue Apr 14, 2020
@carlos-zamora @DHowett
Fire UIA Events for Output and Cursor Movement (#4826)
1bcc85a 
## Summary of the Pull Request
This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen.

## References
Close #2447 - Signaling for new output and cursor
Close #3791 - fixed by signaling cursor changes

## Detailed Description of the Pull Request / Additional comments
- Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client.
- Fire TextChanged automation events when new content is output to the screen.

## Validation Steps Performed
Verified with NVDA [1]

## Narrator
Narrator works _better_, but is unable to detect new output consistently. There is no harm for narrator when this change goes in.

[1] #2447 (comment)
DHowett-MSFT pushed a commit that referenced this issue Apr 14, 2020
@carlos-zamora @DHowett
Reduce CursorChanged Events for Accessibility (#5196)
8de952c 
## Summary of the Pull Request
Reduce the number of times we dispatch a cursor changed event. We were firing it every time the renderer had to do anything related to the cursor. Unfortunately, blinking the cursor triggered this behavior. Now we just check if the position has changed.

## PR Checklist
* [X] Closes #5143


## Validation Steps Performed
Verified using Narrator
Also verified #3791 still works right
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #4826, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Jul 7, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Fire UIA Events for Output and Cursor Movement microsoft/terminal
6 participants
@shanselman @carlos-zamora @DHowett-MSFT @Migod11 @zadjii-msft @cinnamon-msft