Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AutomationProperties for SplitButton #4804

Closed
carlos-zamora opened this issue Mar 4, 2020 · 2 comments
Closed

Update AutomationProperties for SplitButton #4804

carlos-zamora opened this issue Mar 4, 2020 · 2 comments
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

The SplitButton isn't cooperating with me setting the AutomationProperties. I've filed an issue on WinUI here.

Related to...
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Mar 4, 2020
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone Mar 4, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 4, 2020
@DHowett-MSFT DHowett-MSFT added Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 4, 2020
@DHowett-MSFT
Copy link
Contributor

This is v1 work, but it could slip because of a dependency.

@carlos-zamora carlos-zamora mentioned this issue Mar 4, 2020
Merged
2 tasks
ghost pushed a commit that referenced this issue Mar 5, 2020
Polish AutomationProperties and UIA Tree Navigation (#4805)
27342db 
AutomationProperties of interest in this PR include...
- Name: the name of a UI element (generally used as the main identifier
  for it)
- HelpText: an additional description for a more complex UI element
- AccessibilityView[1]
  - Raw: hide from the UIA tree. Only navigate to this if you know what
    you're doing
  - Control: a control without any content in it. Basically, a point at
    which the user can make a decision as to how to navigate the tree or
    invoke an action.
  - Content: a control that also has content to present to the user.

I set a few more AutomationProperties throughout Windows Terminal...
- MinMaxClose Control: hidden (we can/should rely on the true buttons
  that we are hiding)
- SplitButton: Name and Help text (currently ignored due to #4804, but
  having it in the resource file won't cause any problems)
- SearchBox: added a more specific name to the close button
- BackgroundImage: hide it

## References
A few additional work items have been created for tracking...
- SplitButton: #4804

## PR Checklist
* [X] Closes #2099 
* [X] Closes #2102 

## Validation Steps Performed
Verified using Accessibility Insights and Inspect.exe

[1] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-treeoverview
@DHowett-MSFT
Copy link
Contributor

It turns out that this was broken because of something on our side (#5031)

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 2, 2020
@DHowett-MSFT DHowett-MSFT added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 2, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 2, 2020
@DHowett-MSFT DHowett-MSFT added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Apr 2, 2020
donno2048 added a commit to donno2048/terminal that referenced this issue Sep 28, 2020
@donno2048
Polish AutomationProperties and UIA Tree Navigation (#4805)
40dadc2 
AutomationProperties of interest in this PR include...
- Name: the name of a UI element (generally used as the main identifier
  for it)
- HelpText: an additional description for a more complex UI element
- AccessibilityView[1]
  - Raw: hide from the UIA tree. Only navigate to this if you know what
    you're doing
  - Control: a control without any content in it. Basically, a point at
    which the user can make a decision as to how to navigate the tree or
    invoke an action.
  - Content: a control that also has content to present to the user.

I set a few more AutomationProperties throughout Windows Terminal...
- MinMaxClose Control: hidden (we can/should rely on the true buttons
  that we are hiding)
- SplitButton: Name and Help text (currently ignored due to #4804, but
  having it in the resource file won't cause any problems)
- SearchBox: added a more specific name to the close button
- BackgroundImage: hide it

## References
A few additional work items have been created for tracking...
- SplitButton: microsoft/terminal#4804

## PR Checklist
* [X] Closes #2099 
* [X] Closes #2102 

## Validation Steps Performed
Verified using Accessibility Insights and Inspect.exe

[1] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-treeoverview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
2 participants
@carlos-zamora @DHowett-MSFT