Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shortcut action for switching to a specific color scheme #5401

Closed
zadjii-msft opened this issue Apr 17, 2020 · 1 comment · Fixed by #6993
Closed

Add a shortcut action for switching to a specific color scheme #5401

zadjii-msft opened this issue Apr 17, 2020 · 1 comment · Fixed by #6993
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@zadjii-msft
Copy link
Member

Pretty self-explanatory.

{ "action": { "command": "setColorScheme", "name": "<scheme name>"}, "keys": [] }
    [default_interface] runtimeclass SetColorSchemeArgs : IActionArgs
    {
        string Name { get; };
    };

I want this for the command palette, see #5400
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Apr 17, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 17, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 17, 2020
@zadjii-msft zadjii-msft mentioned this issue Apr 21, 2020
Open
52 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 21, 2020
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@zadjii-msft zadjii-msft mentioned this issue May 22, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Jul 21, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 21, 2020
@ghost ghost closed this as completed in #6993 Aug 10, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 10, 2020
ghost pushed a commit that referenced this issue Aug 10, 2020
@zadjii-msft
Add support for changing the active color scheme with an action (#6993)
aee803e 
## Summary of the Pull Request

Adds the `setColorScheme` action, to change the color scheme of the active control to one given by the `name` parameter. `name` is required. If `name` is not the name of a color scheme, the action does nothing.

## References

* Being done as a stepping stone to #6689 

## PR Checklist
* [x] Closes #5401
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

Technically, the action is being done by changing the settings of the current `TerminalSettings` of the `TermControl`. Frankly, it should be operating on a copy of the `TermControl`'s `IControlSettings`, then updating the control's settings, or the Control should just listen for changes to it's setting's properties, and update in real time (without a manual call to `UpdateSettings`. However, both those paths are somewhere unknowable beyond #6904, so we'll just do this for now.

## Validation Steps Performed

* tested manually with a scheme that exists
* tested manually with a scheme that doesn't exist
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 10, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #6993, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Add support for changing the active color scheme with an action microsoft/terminal
3 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft