Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to globals section of settings.json are ignored #5473

Closed
lagbolt opened this issue Apr 22, 2020 · 3 comments
Closed

Changes to globals section of settings.json are ignored #5473

lagbolt opened this issue Apr 22, 2020 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@lagbolt
Copy link

lagbolt commented Apr 22, 2020

Environment

Windows build number: Version 10.0.18362.778
Windows Terminal version (if applicable):   0.11.1121.0

Any other software?

Steps to reproduce

Immediately after I upgraded to 0.11, I started Terminal, opened the settings.json file and made some changes, including two changes to the globals section, changing the defaultProfile and initialRows. I saved the settings.json file and restarted Terminal. The change I made to individual profiles (font size) had taken effect, but not the defaultProfile and initialRows changes.

Expected behavior

When you start Terminal, the initial pane and number of rows should reflect the changes I made to settings.json.

Actual behavior

Initial pane and number of rows were unaffected.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 22, 2020
@DHowett-MSFT
Copy link
Contributor

/dup #5458 Gotta read the release notes for this one, sorry.

@ghost
Copy link

ghost commented Apr 22, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 22, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 22, 2020
@DHowett-MSFT
Copy link
Contributor

(Sorry if my replies to issues like this one are terse: we're having a discovery problem, so people aren't finding the issue we pinned to the top of the repo. Trying to get through them quickly, not necessarily curtly.)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants