Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: close tabs to the right #5524

Closed
Adam13531 opened this issue Apr 24, 2020 · 6 comments · Fixed by #7728
Closed

Feature request: close tabs to the right #5524

Adam13531 opened this issue Apr 24, 2020 · 6 comments · Fixed by #7728
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@Adam13531
Copy link

Description of the new feature/enhancement

Hey, I was hoping for a feature in Windows Terminal that I've seen in many browsers and text editors: being able to close all tabs to the right of the current one. Here are some examples:

Sublime:
image

Firefox:
image

Chrome:
image

ConEmu:
image

The scenario I have is that I keep long-lived tabs like build processes, servers, etc. in the leftmost positions in my terminal, then I have "temporary" tabs on the right. Every once in a while, I end up with 20+ tabs open, so I want to activate the 6th or 7th one and close all tabs to the right to get rid of all of the clutter.

Even just having a customizable keyboard shortcut would be great, but this is the kind of thing that could live in a context menu eventually (#1912).

P.S. much of this text was copy/pasted from here.
@Adam13531 Adam13531 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 24, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 24, 2020
@zadjii-msft
Copy link
Member

Okay yea this is a neat idea.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Apr 24, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 24, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Apr 24, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 25, 2020
@DHowett-MSFT
Copy link
Contributor

Yeah, I love this. Great tag-in for the tab context menu in 1.1+

@mdtauk mdtauk mentioned this issue Apr 25, 2020
Closed
8 tasks
@DHowett-MSFT
Copy link
Contributor

Backlinked from 1912. Thanks!

@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. labels Jul 9, 2020
@Chips1234
Copy link
Contributor

How about "Close all except for this tab"?

@zadjii-msft
Copy link
Member

That certainly fits in well with this request IMO. I really like the Firefox way of doing it:
image

"Close Tab" is a top level entry, and then I imagine a "Close..." option with nested entries for:

  • Close other tabs
  • Close tabs to the right
  • Close pane
  • Close other panes in this tab

@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2020
Closed
3 tasks
@zadjii-msft zadjii-msft mentioned this issue Aug 4, 2020
Merged
3 tasks
zadjii-msft added a commit that referenced this issue Aug 12, 2020
@zadjii-msft
Spec for global action IDs (#7175)
c241f83 
## Summary of the Pull Request

⚠️ This spec has been moved from #6902. That version was branched off the new tab menu customization, and had a terribly convoluted git history. After discussion with the team, we've decided that it's best that this spec is merged atomically _first_, and used as the basis for #5888, as opposed to the other way around.

> This document is intended to serve as an addition to the [Command Palette Spec],
> as well as the [New Tab Menu Customization Spec].
> 
> As we come to rely more on actions being a mechanism by which the user defines
> "do something in the Terminal", we'll want to make it even easier for users to
> re-use the actions that they've already defined, as to reduce duplicated json as
> much as possible. This spec proposes a mechanism by which actions could be
> uniquely identifiable, so that the user could refer to bindings in other
> contexts without needing to replicate an entire json blob.
> 

## PR Checklist
* [x] Specs: #6899
* [x] References: #1571, #1912, #3337, #5025, #5524, #5633
* [x] I work here

## Detailed Description of the Pull Request / Additional comments
_\*<sup>\*</sup><sub>\*</sub> read the spec  <sub>\*</sub><sup>\*</sup>\*_



[Command Palette Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%232046%20-%20Command%20Palette.md
[New Tab Menu Customization Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%231571%20-%20New%20Tab%20Menu%20Customization.md
@skyline75489 skyline75489 mentioned this issue Sep 15, 2020
Closed
@mpela81 mpela81 mentioned this issue Sep 24, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 24, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 15, 2020
zadjii-msft pushed a commit that referenced this issue Oct 15, 2020
@mpela81
Add Close... option to Tab context menu (#7728)
004da88 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Add a "Close..." option to the tab context menu, with nested entries to close tabs to the right and close other tabs (actions already available)
![immagine](https://user-images.githubusercontent.com/1140981/94178005-c7e03600-fe9a-11ea-9f87-c6f4895d4cf3.png)

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References
#1912 

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #5524
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
First contribution 🙂
Tried to follow some suggestions from #1912 (comment)

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7728, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

@EdwinChan EdwinChan mentioned this issue May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add Close... option to Tab context menu mpela81/terminal
4 participants
@Adam13531 @DHowett-MSFT @zadjii-msft @Chips1234