Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tab-bar/title bar for dragging window around #564

Closed
Paul-Weisser opened this issue May 8, 2019 · 14 comments · Fixed by #1948
Closed

Use tab-bar/title bar for dragging window around #564

Paul-Weisser opened this issue May 8, 2019 · 14 comments · Fixed by #1948
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@Paul-Weisser
Copy link

I think its really nice that you can put the terminal-tabs in your titlebar but I got an issue there.

You can't move the window around klicking on the blank space in the the-bar to move the window around (highlighted in the screenshot).

Since people are moving their terminal quite often it would be nice to offer this space, so you can drag your terminal around.

grafik

@glen-84
Copy link

glen-84 commented May 8, 2019

Duplicate of #528 (?).

@Paul-Weisser
Copy link
Author

Paul-Weisser commented May 8, 2019

Duplicate of #528 (?).

No, the issue you mentioned describes losing focus of the current terminal-tab.

This issue is about dragging the whole window around.

Edit: This is a explicit feature-request

@oising
Copy link
Collaborator

oising commented May 8, 2019

@Paul-Weisser It is a duplicate of #528 -- that issue specifically explains that when one is trying to drag the window to move it, it doesn't work and additionally this action blocks the current tab for input.

@Paul-Weisser
Copy link
Author

Paul-Weisser commented May 8, 2019

@Paul-Weisser It is a duplicate of #528 -- that issue specifically explains that when one is trying to drag the window to move it, it doesn't work and additionally this action blocks the current tab for input.

please read #528 till the end as zadjii-msft is adressing this issue as an external issue...

@zadjii-msft
Copy link
Member

Okay, IMO, lets leave #528 as "the tab row steals focus from the terminal".

This is now the "use the tab bar to drag the window" thread.

@zadjii-msft
Copy link
Member

As I mentioned in #528, this is a bug with XAML Islands currently, where we're not getting WM_NCHITTEST messages for the XAML Islands area (which hosts the tab control). They're working on fixing that for us - once we get those messages, we'll be able to hittest ourselves against the actual tabs, vs the "background" of the tabs.

@zadjii-msft zadjii-msft added the Resolution-External For issues that are outside this codebase label May 8, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 8, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Area-User Interface Issues pertaining to the user interface of the Console or Terminal and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@notlaforge
Copy link

@zadjii-msft does that mean the fix will require another Windows build?

@fearthecowboy
Copy link
Member

fearthecowboy commented Jun 12, 2019

I had a couple thoughts on temporary work around for this:

  • is it possible to move the +v control to the left side, and then have the tab bar no wider than the tabs themselves? (of course, you'd probably want to trim the text in tabs so it didn't show the whole path!)

  • or, can an additional invisible control be placed over top the empty area in the tab bar that can give you the message to allow you to drag?

I haven't had time to test these, if someone can or gets to it before me, it might be an acceptable workaround.

@DHowett-MSFT
Copy link
Contributor

This'll be addressed by #929.

@DHowett-MSFT
Copy link
Contributor

Moved into v0.3, the second public preview.

@sandercox
Copy link

hoping that would also fix the ability to drag just above the tab.. as I'm used to dragging from there with apps like Chrome as well.

@zadjii-msft zadjii-msft changed the title Use tab-bar for dragging window around Use tab-bar/title bar for dragging window around Jul 2, 2019
@zadjii-msft zadjii-msft self-assigned this Jul 11, 2019
@zadjii-msft zadjii-msft removed the Resolution-External For issues that are outside this codebase label Jul 11, 2019
@ghost ghost added the In-PR This issue has a related PR label Jul 12, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 18, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #1948, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

@BernierCR
Copy link

Hmm thanks for the work.

But it seems that so far, all that has really happened is moving the drop down menu closer to the tabs. You can still only drag from the small area to the right of the drop down menu. If you have just one or two tabs, this area is now a bit larger then it was before. But once you get to 3 or 4 tabs, it's just as small again.

I understand software development takes time. I do it myself. But the news exaggerated this. Keep up the good work anyways.

But let me know when you can drag the individual tabs around, when you can rename the tabs with right click, not have to mess with programmatic title manipulations, and when you can drag the whole window around by the area above the tabs.

Now that would be news worthy.

@gregpakes
Copy link

Agree with @BernierCR. This update is an improvement, but it still doesn't behave like other tabbed applications.

For example, in chrome, you can drag the window by clicking the small space above any tab. That still doesn't work in the terminal.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.