Apply a GDI region to the top level Island window to allow dragging with a single Xaml Island #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniksa
reviewed
May 22, 2019
miniksa
added
Area-User Interface
Co-Authored-By: Michael Niksa <miniksa@microsoft.com>
Co-Authored-By: Michael Niksa <miniksa@microsoft.com>
zadjii-msft
reviewed
May 22, 2019
zadjii-msft
requested changes
May 30, 2019
ghost
added
Needs-Author-Feedback
|
/azp run |
1 similar comment
|
/azp run |
DHowett-MSFT
approved these changes
Jun 25, 2019
carlos-zamora
approved these changes
Jun 25, 2019
miniksa
approved these changes
Jun 25, 2019
|
kinda odd how the borders at the top are rounded. Very few apps have rounded borders on Windows 10. One is Math Input Panel. |
|
They already said this will change in the future, Windows is getting rounded borders everywhere |
|
Introducing rounded corners after years of persistent sharp corners is hard and we don't have rounded corners right now anyway. I got a little off topic as it's more of a topic for the winui repo |
|
The real technical reason this is happening is that we're suppressing window decorations and drawing over them, and the kernel component in charge of that (don't ask) gives us a region with rounded corners. |
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 2, 2019
…ith a single Island (microsoft#929) * Use a region to cut off the dragable region * Use proper measurements for the draggable area * Working better, paint works most of the time * Fix a bug where paint is incomplete when double clicking the dragbar * Remove old fork on XamlApplication * Upgrade to XamlApp preview6.2 * Add Microsoft.VCRTForwarders to make it easy to dogfood Co-Authored-By: Michael Niksa <miniksa@microsoft.com> Co-Authored-By: Mike Griese <migrie@microsoft.com>
This was referenced Jul 8, 2019
This was referenced Jul 9, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
…ith a single Island (microsoft#929) * Use a region to cut off the dragable region * Use proper measurements for the draggable area * Working better, paint works most of the time * Fix a bug where paint is incomplete when double clicking the dragbar * Remove old fork on XamlApplication * Upgrade to XamlApp preview6.2 * Add Microsoft.VCRTForwarders to make it easy to dogfood Co-Authored-By: Michael Niksa <miniksa@microsoft.com> Co-Authored-By: Mike Griese <migrie@microsoft.com>
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When Terminal is drawing in the non client area we no longer create 2 islands. Instead we create a single island and create a region that "pokes" the drag-able title bar area in the top right corner of the main window of terminal.
This change also fixes:
References
PR Checklist
Detailed Description of the Pull Request / Additional comments