"shift extend selection" feature doesn't work in the click->shift-click case because single-cell selection is gone

[ymkun]

Environment

Windows build number: [19041.208  wsl ]
Windows Terminal version (if applicable): 0.11.1251.0

Any other software?

Steps to reproduce

1. Single click.
2. Hold SHIFT and single click an unselected region.

Expected behavior

Region between two click should be selected.

Actual behavior

region between two click hasn't been selected.
I remeber this feature has been released in "Windows Terminal Preview v0.9.433.0", said: "You can now hold down Shift and click to extend your selection (#4404)". But in recent releases, it gone.

[DHowett-MSFT]

So, fair enough. Shift only works to extend an actual extant selection Since single-click no longer selects a cell, it doesn't comprise an active selection.

We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.)

[ymkun]

So, fair enough. Shift only works to extend an actual extant selection Since single-click no longer selects a cell, it doesn't comprise an active selection.

We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.)

Thanks. It's just a little inconvenient when select a long region now.

[Don-Vito]

@DHowett, @carlos-zamora, @ymkun - ConEmu does something that is IMHO more intuitive:

1. Shift+Click - selects single cell
2. The next Shift+Click expands this selection.

If you like this approach, I can commit (it is less than one-liner 😊)

[DHowett]

Sounds great, with one caveat.

We need to figure out how this works with Shift suppressing VT mouse mode. Will any single shift-click on a mouse mode application cause a single cell selection?

I might be okay with that.

[Don-Vito]

@DHowett - I am not sure I understood the concern, can you please explain?

I mean I tried this in tmux with mouse mode on, and it works exactly like shift +drag one char (but with no need to drag).

Guess I am missing something.

[DHowett]

Sure.

I was worried that introducing this behavior would make it difficult to single-click on the terminal itself when there was a mouse mode application running without selecting a single cell.

However, thinking about it more: There is no reason to click on the terminal itself during mouse mode unless you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL!

[Don-Vito]

Sure.

I was worried that introducing this behavior would make it difficult to single-click on the terminal itself when there was a mouse mode application running without selecting a single cell.

However, thinking about it more: There is no reason to click on the terminal itself during mouse mode unless you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL!

I will try this. If works as expected - should I submit PR under this ticket?

[DHowett]

Absolutely! 😄 We love your PRs.

[Don-Vito]

@DHowett - lol. Actually I am asking if I should mark the PR as "Closing" this one.. or not. BTW - URL works like a charm

[DHowett]

Yeah, I think that your proposal is sufficient to solve this issue!

[ghost]

🎉This issue was addressed in #8611, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

• Release Notes
• Store Download