Ability to disable some dead keys #5784

gpotter2 · 2020-05-07T10:55:10Z

Description of the new feature/enhancement

Feature: Ability to disable SOME dead keys.

Motivation

It might be hard to understand for people who have sensible layouts, but many keyboard layouts have dead keys that are very cumbersome when programming.

I personally use the terminal on the daily, and the tilde ~ is used a lot in Linux. On my AZERTY default layout, ~ acts as a dead key: i need to type it then add a space to get a single ~. See the layout below

~ needs ALTGR + 2 + space. This is exhausting. We also have a dead ^ that could use this feature.

Notes

Ubuntu provides very useful layouts made for coders, that disable the cumbersome dead keys: https://askubuntu.com/questions/56560/what-exactly-is-meant-by-eliminate-dead-keys . Windows doesn't provide this natively, thus this feature request (I would never expect this to be added to the main OS...)
Some people will say they use ñ while coding, or ê. Even if the Terminal has great:tm: support for UTF8, I'm not among them. I belive this is a tiny minority
I'm sure many people have that one dead key they wish they could get rid of. If this feature was builtin the terminal, it would allow a better coding experience for the people that only use those characters in the terminal anyways. This could also be profile based...

Do people also want that

Google for "disable dead keys"
It seems the germans also have tons of dead keys: many articles try to workaround those: https://zauner.nllk.net/post/0014-windows-no-dead-keys/

For the user, It could be as simple a config value to disable dead keys using their key codes (?) such as

disable_dead_keys: [50]  # the 2/~ key code

Thanks a lot for you time, the Terminal is absolutely amazing and it just keeps getting better ! Cheers

The text was updated successfully, but these errors were encountered:

zadjii-msft · 2020-06-09T13:07:12Z

This doesn't seem entirely unreasonable to me. We might want to workshop how we specify these keys in json, but I think the idea sounds valid. I'm gonna summon our keyboard layout expert @lhecker to see if he's got any thoughts on the matter ☺️

(sorry for the long silence)

lhecker · 2020-06-09T16:01:30Z

Yeah that's probably relatively easy to implement. Add a config setting like so (minus the UB I introduced), and add a && !disabledDeadKeys.contains(vkey) here.
I'd be able to implement that next weekend or so. 👍

gpotter2 · 2020-06-13T07:14:01Z

Thanks a lot for looking into this !

lhecker · 2020-06-14T21:39:10Z

I had the idea of adding a command called "passthrough" to the keybindings.
If you e.g. add a { "command": "passthrough", "keys": "~" }, binding it would then pass the key event (with the character ~) to the shell instead of deferring the event to the character event handler.
In order to support this I'd modify IKeyBindings::TryKeyChord to return a ternary instead of a boolean.
What do you think?

lhecker · 2020-09-14T11:17:46Z

Ah! I forgot about this issue! While it's slightly cumbersome I believe this functionality can now be achieved in the v1.3 preview version using the new sendInput command.
If that's sufficient for you @gpotter2 would you like to try it out in the preview version?

gpotter2 · 2020-09-14T12:33:20Z

It's working great ! The only issue now is that there is no way to register AltGR in the current key binders :/

lhecker · 2020-09-14T12:38:58Z

The current key bninding interface doesn't make a distinction between left and right Ctrl/Alt.
We'll have to extend that interface and teach it to do so first. It'll also require adding logic to make it parse e.g. "LeftCtrl"/"RrightCtrl" and teach it that "Ctrl" is an alias for the presence of either of those keys. Only then can we alias "AltGr" as "RightAlt+LeftCtrl". Unfortunately that's clearly another feature that needs to implemented unrelated to both sendInput and this issue. 🤔

gpotter2 · 2020-09-14T15:32:38Z

Actually, there's an issue: it seems the dead key are not consumed (which is the whole point of this issue), even if made a shortcut.
For instance on my AZERTY keyboard, there's a ^ that is a dead key. If i use:

{ "command": { "action": "sendInput", "input": "b" }, "keys": "^" }

If i then press once the ^ key (which is a dead key) then a, I'll get:

bâ

lhecker · 2020-09-14T16:10:43Z

I'll investigate this. 👍

Let's assume the user has bound the dead key ^ to a sendInput command that sends "b". If the user presses the two keys ^a it'll produce "bâ", despite us marking the key event as handled. We can use `ToUnicodeEx` to clear such dead keys from the keyboard state and should make use of that for keybindings. Unfortunately `SetKeyboardState` cannot be used for this purpose as it doesn't clear the dead key state. Validation * Enabled a German keyboard layout * Added the following two keybindings: { "command": { "action": "sendInput", "input": "x" }, "keys": "q" }, { "command": { "action": "sendInput", "input": "b" }, "keys": "^" } * Pressed the following keys → ensured that the given text is printed: * q → x * ´ → nothing * a → á * ^ → b * a → a (previously this would print: â) * ´ → nothing * ^ → b * a → a (unfortunately we cannot specifically clear only ^) Closes #5784

gpotter2 · 2020-10-20T06:31:18Z

Thanks a lot for your work on this !!!
❤️

Let's assume the user has bound the dead key ^ to a sendInput command that sends "b". If the user presses the two keys ^a it'll produce "bâ", despite us marking the key event as handled. We can use `ToUnicodeEx` to clear such dead keys from the keyboard state and should make use of that for keybindings. Unfortunately `SetKeyboardState` cannot be used for this purpose as it doesn't clear the dead key state. Validation * Enabled a German keyboard layout * Added the following two keybindings: { "command": { "action": "sendInput", "input": "x" }, "keys": "q" }, { "command": { "action": "sendInput", "input": "b" }, "keys": "^" } * Pressed the following keys → ensured that the given text is printed: * q → x * ´ → nothing * a → á * ^ → b * a → a (previously this would print: â) * ´ → nothing * ^ → b * a → a (unfortunately we cannot specifically clear only ^) Closes #5784 (cherry picked from commit 4099aac)

ghost · 2020-11-11T18:05:32Z

🎉This issue was addressed in #7686, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

ghost · 2020-11-11T18:05:35Z

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

ghost · 2020-11-11T18:09:26Z

🎉This issue was addressed in #7686, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

ghost · 2020-11-11T18:09:28Z

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

gpotter2 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 7, 2020

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 7, 2020

zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Jun 9, 2020

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 9, 2020

zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 9, 2020

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 9, 2020

zadjii-msft added this to the Terminal Backlog milestone Jun 9, 2020

lhecker mentioned this issue Sep 20, 2020

Fix #5784: Key bindings won't consume dead keys #7686

Merged

6 tasks

ghost added the In-PR This issue has a related PR label Sep 20, 2020

DHowett closed this as completed in #7686 Oct 19, 2020

ghost added Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Oct 19, 2020

ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 19, 2020

gpotter2 mentioned this issue May 26, 2021

keybindings of dead keys using AltGr+X #10218

Open

CptPotato mentioned this issue Dec 2, 2022

Windows dead keys problem helix-editor/helix#4864

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to disable some dead keys #5784

Ability to disable some dead keys #5784

gpotter2 commented May 7, 2020 •

edited

zadjii-msft commented Jun 9, 2020

lhecker commented Jun 9, 2020

gpotter2 commented Jun 13, 2020

lhecker commented Jun 14, 2020

lhecker commented Sep 14, 2020

gpotter2 commented Sep 14, 2020

lhecker commented Sep 14, 2020 •

edited

gpotter2 commented Sep 14, 2020

lhecker commented Sep 14, 2020

gpotter2 commented Oct 20, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

Ability to disable some dead keys #5784

Ability to disable some dead keys #5784

Comments

gpotter2 commented May 7, 2020 • edited

Description of the new feature/enhancement

zadjii-msft commented Jun 9, 2020

lhecker commented Jun 9, 2020

gpotter2 commented Jun 13, 2020

lhecker commented Jun 14, 2020

lhecker commented Sep 14, 2020

gpotter2 commented Sep 14, 2020

lhecker commented Sep 14, 2020 • edited

gpotter2 commented Sep 14, 2020

lhecker commented Sep 14, 2020

gpotter2 commented Oct 20, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

ghost commented Nov 11, 2020

gpotter2 commented May 7, 2020 •

edited

lhecker commented Sep 14, 2020 •

edited