Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen toggle commandline parameter #5801

Closed
Firehawke opened this issue May 8, 2020 · 2 comments · Fixed by #6139
Closed

Fullscreen toggle commandline parameter #5801

Firehawke opened this issue May 8, 2020 · 2 comments · Fixed by #6139
Labels
Area-Commandline wt.exe's commandline arguments Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.1

Comments

@Firehawke
Copy link

Description of the new feature/enhancement

A command-line parameter that can toggle fullscreen status; initially since you can't modify existing WT sessions (to add or remove tabs) yet you wouldn't be able to use it to turn FS off, but you could use it when running a WT script to open several tabs to make those fullscreen.

Proposed technical implementation details (optional)
@Firehawke Firehawke added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 8, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 8, 2020
@DHowett-MSFT
Copy link
Contributor

Not bad. Hooked up to #4632.

@DHowett-MSFT DHowett-MSFT added Area-Commandline wt.exe's commandline arguments Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 8, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone May 8, 2020
@DHowett-MSFT DHowett-MSFT added the Product-Terminal The new Windows Terminal. label May 8, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 8, 2020
@zadjii-msft zadjii-msft mentioned this issue May 8, 2020
Open
40 tasks
@zadjii-msft zadjii-msft mentioned this issue May 22, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label May 22, 2020
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels May 28, 2020
@ghost ghost closed this as completed in #6139 Jun 1, 2020
ghost pushed a commit that referenced this issue Jun 1, 2020
@zadjii-msft
Add support for --fullscreen, --maximized (#6139)
8987486 
## Summary of the Pull Request

Adds two new flags to the `wt.exe` alias:

* `--maximized,-M`: Launch the new Terminal window maximized. This flag cannot be combined with `--fullscreen`.
* `--fullscreen,-F`: Launch the new Terminal window fullscreen. This flag cannot be combined with `--maximized`.

## References
* This builds on the work done in #6060.
* The cmdline args megathread: #4632

## PR Checklist
* [x] Closes #5801
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

* I had to move the commandline arg parsing up a layer from `TerminalPage` to `AppLogic`, because `AppLogic` controls the Terminal's settings, including launch mode settings. This seems like a reasonable change, to put both the settings from the file and the commandline in the same place.
  - **Most of the diff is that movement of code**

* _"What happens when you try to pass both flags, like `wtd -M -F new-tab`?"_:
![image](https://user-images.githubusercontent.com/18356694/82679939-3cffde00-9c11-11ea-8d88-03ec7db83e59.png)

## Validation Steps Performed
* Ran a bunch of commandlines to see what happened.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jun 1, 2020
@ghost
Copy link

ghost commented Jun 18, 2020

🎉This issue was addressed in #6139, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Commandline wt.exe's commandline arguments Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.1
Development

Successfully merging a pull request may close this issue.

Add support for --fullscreen, --maximized microsoft/terminal
3 participants
@DHowett-MSFT @zadjii-msft @Firehawke