Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal window titlebar is too big compared with console and other native windows apps #5906

Closed
ghost opened this issue May 14, 2020 · 13 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ghost
Copy link

ghost commented May 14, 2020

Steps to reproduce

image

image

Expected behavior

The Terminal titlebar size should be the same as that of other windows apps. Currently, Windows Terminal feels like a UWP app.

Actual behavior

Windows Terminal titlebar size is too big and feels like a UWP app.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 14, 2020
@zadjii-msft
Copy link
Member

I mean, the Terminal is an application that's using UWP XAML 😉

You could also try

"showTabsInTitlebar": false,
"alwaysShowTabs": true

to force the Terminal to use a standard windows titlebar.

Largely, I'm gonna close this as a /dup of #1375, as that thread has much more discussion of the design in it

@ghost
Copy link

ghost commented May 14, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 14, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 14, 2020
@ghost
Copy link
Author

ghost commented May 14, 2020

to force the Terminal to use a standard windows titlebar.

The problem is not about whether or not it has tabs.
The problem is that the tabs make the titlebar frame larger and it looks odd. If it had tabs, but with a smaller titlebar frame, and with a smaller default window size, it would absolutely not be a problem.

@ghost
Copy link
Author

ghost commented May 14, 2020

@zadjii-msft And it's not a dupe of #1375 insofar as that issue seems like a ignore dump of complaints about terminal. None of the issues mentions the titlebar height and scaling, and this is also not acknowledged in there as well.

@mdtauk
Copy link

mdtauk commented May 14, 2020

to force the Terminal to use a standard windows titlebar.

The problem is not about whether or not it has tabs.
The problem is that the tabs make the titlebar frame larger and it looks odd. If it had tabs, but with a smaller titlebar frame, and with a smaller default window size, it would absolutely not be a problem.

You chose not to compare the Titlebar with Google Chrome or Microsoft Edge, despite the tabs being in the titlebar...

image

When comparing these, Windows Terminal is actually shorter

@ghost
Copy link
Author

ghost commented May 14, 2020

You chose not to compare the Titlebar with Google Chrome or Microsoft Edge, despite the tabs being in the titlebar...

FYI @mdtauk and @zadjii-msft

  1. That's not how chrome looks like on my computer, and as far as I know, for lots of people as well, search for discussions about the flag /force-device-scale-factor=1. On a 15 inch, fullhd notebook display, which is configured by default to run at 125% scaling, UWP apps look giant, and Chromium based browsers look giant as well without the flags.
  2. Chrome usually runs maximized. Terminal doesn't. When chrome is maximized, the tabs gets smaller.
  3. You're right, Terminal is indeed shorter than these browsers when they aren't maximized, and when they aren't launched with the flags /force-device-scale-factor=1.
  4. Terminal still looks stupid.

I've attached a screenshot comparing Chrome on my machine with windows terminal.

image

I've also attached a comparison with windows explorer, chrome with the flag, and terminal.
image

@ghost
Copy link
Author

ghost commented May 14, 2020

And as a side note, for Microsoft Edge, making the UI smaller or giving users to option to change the scaling is in actually in discussion.

@mdtauk
Copy link

mdtauk commented May 14, 2020

I did not realise you were comparing scaled UI to 100% dpi UI.

When running at 100% dpi scaling, Chrome and Edge are still larger than Windows Terminals however. So I don't think it is right to expect a standard height TitleBar, with tabs in them.

@ghost
Copy link
Author

ghost commented May 14, 2020

I did not realise you were comparing scaled UI to 100% dpi UI.

Yes, but at 100% DPI everything else on windows is then too small.
Currently, my choice is to break everything else, or to break UWP apps and run Chrome with the scaling flag.

That's why I avoid UWP apps. Is there a way to change the Terminal UI scaling only, without affecting the rest of the OS, or should I not use Windows Terminal instead?

I really don't think this issue should be closed.

@zadjii-msft
Copy link
Member

I think what you're really looking for is #5911.

As soon as apps start customizing the titlebar, all bets are off as to what size the titlebar is.
image

Or take Spotify for an example, which doesn't even really have a titlebar:
image

So there's already basically no consistency here.

We've made a stylistic choice to make the titlebar of the Terminal as big as it is, because it fits the tabs we have rather nicely. Though, I acknowledge that this might not be everyone's preference, so let's make a setting for it. We're already discussing a huge number of "theming" properties in #3327, so this seems like it would be a nice fit.

@ghost
Copy link
Author

ghost commented May 14, 2020

@zadjii-msft Yes, #5911 is the issue. It would be interesting to have one setting to force the entire scaling as well. This is really important for me, and Windows Terminal, as all well as any other UWP app, can't be used without it.

@ghost
Copy link
Author

ghost commented May 14, 2020

Teams UI kind of sucks, office has gotten much worse in recent times - it used to be more compact, and windows terminal also sucks.
I won't really comment on Spotify. But at least teams and Spotify both provide a zoom option that affects the entire UI.
AFAIK both terminal and office do not provide that option.

@MostHated
Copy link

I found this thread due to feeling that the title bar was way too big as well. I would love to be able to specify the size in px or something similar. I realize it has tabs, so it is bigger. It would be ideal if the tab size would just scale with the size of the title bar. It just feels like wasted space

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants