Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really hard to resize via top margin when toggleFocusMode is enabled #7012

Closed
iamsergio opened this issue Jul 22, 2020 · 6 comments
Closed

Really hard to resize via top margin when toggleFocusMode is enabled #7012

iamsergio opened this issue Jul 22, 2020 · 6 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@iamsergio
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.19041.388]
Windows Terminal version: 1.2.2022.0

Steps to reproduce

Hide the terminal's title bar and tabs by enabling the new setting 'toggleFocusMode'.
For example, by adding { "command": "toggleFocusMode", "keys": "ctrl+shift+t" }, to your keybindings.

Once you've hidden the title bar, hover over the top window border with your mouse and resize it a bit.
Try resizing it a second time, it no longer works.

Resizing via left, bottom or right margins continue to work though.

Expected behavior

Expected that resizing via the top frame/border still worked.

Actual behavior

Not possible to resize vertically via top-border.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 22, 2020
@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

This is not by design, lol.

@WSLUser
Copy link
Contributor

WSLUser commented Jul 22, 2020 •
edited
Loading

Really? I've seen many games where you couldn't. But you could move the window or toggle fullscreen on/off.

@DHowett
Copy link
Member

DHowett commented Jul 22, 2020

If we're going to support resize on the bottom, left and right borders we should support it on the top too.

@zadjii-msft
Copy link
Member

Oh derp, I mentioned this is #6804, but forgot to file an issue for it

KNOWN ISSUE: Upon resizing the NCIW, the top frame margin disappears, making that border disappear entirely. 6356aaf has a bunch of WIP work for me trying to fix that, but I couldn't get it quite right.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 22, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 22, 2020
@Don-Vito Don-Vito mentioned this issue Nov 3, 2020
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Nov 3, 2020
@ghost ghost closed this as completed in 990628a Nov 3, 2020
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 3, 2020
DHowett pushed a commit that referenced this issue Nov 3, 2020
@Don-Vito @DHowett
7012: top margin disappears upon resize in focus mode (#8140)
5bfbebe 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
In the focus mode the top border disappears upon resize. While this behavior is expected in the maximized / full screen mode, it should not happen in the focus mode.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? -->
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #7012
* [x] CLA signed
* [ ] Tests added/passed - nope, only manual testing
* [ ] Documentation updated - irrelevant
* [ ] Schema updated - irrelevant
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
_GetTopBorderHeight method returns 0 when maximized or no title bar is visible. However the existence of top border has nothing to do with whether the title bar is visible. We want to leave the border as long as the window is not in some form of maximizing (maximized / full screen)
<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
* Manual - dragging, resizing, maximizing both in focus and non focus modes + full screen testing

(cherry picked from commit 990628a)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8140, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8140, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
4 participants
@iamsergio @DHowett @zadjii-msft @WSLUser