Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include hyperlinks in HTML copy #7565

Open
PankajBhojwani opened this issue Sep 8, 2020 · 3 comments
Open

Include hyperlinks in HTML copy #7565

PankajBhojwani opened this issue Sep 8, 2020 · 3 comments
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@PankajBhojwani
Copy link
Contributor

Description of the new feature/enhancement

When a user does a HTML copy of text to the clipboard, hyperlink information should be copied over as well.
@PankajBhojwani PankajBhojwani added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-VT Virtual Terminal sequence support Product-Terminal The new Windows Terminal. labels Sep 8, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 8, 2020
@PankajBhojwani PankajBhojwani removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 8, 2020
@PankajBhojwani PankajBhojwani mentioned this issue Sep 8, 2020
Open
22 tasks
@DHowett DHowett added this to the Terminal v2.0 milestone Sep 8, 2020
@DHowett DHowett added Issue-Task It's a feature request, but it doesn't really need a major design. Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-VT Virtual Terminal sequence support Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) labels Sep 14, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, Backlog Jan 4, 2022
@DHowett
Copy link
Member

DHowett commented Jul 19, 2023

Drive-by thought: should we include the hyperlink's ID somewhere in the generated HTML, like in an id attribute? I'm thinking about the case where an application emits multiple physical copies of the same logical link.

@lhecker
Copy link
Member

lhecker commented Jul 19, 2023

Using the same id on multiple links wouldn't work reliably since they're supposed to be unique. Is the ID attribute relevant outside of the VT handling?

@DHowett
Copy link
Member

DHowett commented Jul 19, 2023

The ID actually doesn't matter to VT handling - it is for emitting two parts of the same hyperlink, and making sure that they act as a single link. It only matters for user experience.

Consider a terminal multiplexer like tmux. When it is displaying two panes side by side, it will need to hard-wrap the text in both panes. It will break up a hyperlink into two lines, separated by unrelated text. If it uses the same ID on both of those lines, they will both highlight when the user hovers over one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@DHowett @lhecker @zadjii-msft @PankajBhojwani