Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focusMode option for launchMode setting #7825

Closed
Memphizzz opened this issue Oct 4, 2020 · 3 comments · Fixed by #7873
Closed

focusMode option for launchMode setting #7825

Memphizzz opened this issue Oct 4, 2020 · 3 comments · Fixed by #7873
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.5

Comments

@Memphizzz
Copy link

Memphizzz commented Oct 4, 2020 •
edited

Description of the new feature/enhancement

Besides having maximized and fullscreen, would it be possible to please also have the option to start the terminal in FocusMode?

Proposed technical implementation details (optional)
@Memphizzz Memphizzz added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 4, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 4, 2020
@zadjii-msft
Copy link
Member

Yes yes yes. I could have swore I already filed this one - this is something I've been wanting to do. Thanks!

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 5, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 5, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.5 milestone Oct 5, 2020
@zadjii-msft zadjii-msft self-assigned this Oct 5, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 5, 2020
Open
40 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 5, 2020
@ghost ghost mentioned this issue Oct 10, 2020
Closed
@Don-Vito Don-Vito mentioned this issue Oct 10, 2020
Merged
@Don-Vito
Copy link
Contributor

Duplicate of #7124

@ghost ghost added the In-PR This issue has a related PR label Oct 14, 2020
@ghost ghost closed this as completed in #7873 Oct 14, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 14, 2020
ghost pushed a commit that referenced this issue Oct 14, 2020
@Don-Vito
7124: Add focus and maximizedFocus launch modes (#7873)
f86045e 
This commit introduces two new launch modes: focus and maximizedFocus. 
* Focused mode, behaves like a default mode, but with the Focus Mode
  enabled.
* Maximized focused mode, behaves like a Maximized mode, but with the
  Focus Mode enabled.

There two ways to invoke these new modes:
* In the settings file: you set the "launchMode" to either "focus" or
  "maximizedFocus"
* In the command line options, you can path -f / --focus, which is
  mutually exclusive with the --fullscreen, but can be combined with the
  --maximized:
  * Passing -f / --focus will launch the terminal in the "focus" mode
  * Passing -fM / --focus --maximized will launch the terminal in the
    "maximizedFocus" mode

This should resolve a relevant part in the command line arguments
mega-thread #4632

Closes #7124
Closes #7825
Closes #7875
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7873, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.5
Development

Successfully merging a pull request may close this issue.

7124: Add focus and maximizedFocus launch modes Don-Vito/terminal
3 participants
@Don-Vito @Memphizzz @zadjii-msft