Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands. #7915

Closed
DasaradhaKamjula opened this issue Oct 13, 2020 · 6 comments
Closed

[Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands. #7915

DasaradhaKamjula opened this issue Oct 13, 2020 · 6 comments
Assignees
@zadjii-msft
Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020 •
edited
Loading

User Experience:
Vision impairment users will not be able to view the text clearly if the Luminosity ratio is less than 4.5:1 .

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.verify the Luminosity ratio for shortcut text.

Actual:
Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut texts appended to the commands.(For Example: Luminosity ratio of Close pane command shortcut text Ctrl+Shift+W is 4.04:1 )

Expected:
Luminosity ratio should be greater than 4.5:1 for the short cut texts which are appended to the commands
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft
Copy link
Member

Yep this is reasonable. I bet we could make the background of the keys even darker (in dark mode) relative to the cmdpal background, and that'll probably look good.

@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Oct 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 13, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 13, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 13, 2020
Open
52 tasks
@zadjii-msft zadjii-msft self-assigned this Oct 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 15, 2020
Merged
2 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Oct 15, 2020
DHowett pushed a commit that referenced this issue Oct 15, 2020
@zadjii-msft
Increase contrast ratio on the CmdPal shortcut text (#7937)
9d911c0 
Related to #7915.
DHowett pushed a commit that referenced this issue Oct 19, 2020
@zadjii-msft @DHowett
Increase contrast ratio on the CmdPal shortcut text (#7937)
67e2057 
Related to #7915.

(cherry picked from commit 9d911c0)
@cinnamon-msft cinnamon-msft added the HCL-E+D Accessibility tracking label Oct 20, 2020
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Chandresh1007 Chandresh1007 added A11yWCAG Accessibility tracking HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@DHowett
Copy link
Member

DHowett commented Jan 6, 2021

This issue was fixed in #7937 and deployed to production in November.

@awalia13 awalia13 added the Fixed Issues assigned by the accessibility team that have been fixed. label Jan 6, 2021
@zadjii-msft
Copy link
Member

@awalia13 / @DasaradhaKamjula If this is confirmed as fixed, can we close this issue now?

@zadjii-msft
Copy link
Member

@Chandresh1007 If this is confirmed as fixed, can we close this issue now?

@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11ySev3 Accessibility tracking label Jun 10, 2021
@Priyanka-Chauhan123
Copy link
Collaborator

Issue is fixed. Verified on Windows terminal version: 1.8.1521.0 and OS version: Win 10 build 21390.2025. Hence, closing the bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jun 23, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jan 9, 2024
@Priyanka-Chauhan123
Copy link
Collaborator

Closing the bug as issue has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
7 participants
@DHowett @zadjii-msft @DasaradhaKamjula @awalia13 @cinnamon-msft @Chandresh1007 @Priyanka-Chauhan123