Make the Command Line Mode easier to access

[Don-Vito]

Description of the new feature/enhancement

Today, to get to the command line mode I need to open the action mode and then to delete a ">" symbol, which is not very convenient.

While discussing this with @zadjii-msft few ideas were raised:

1. Adding a separate binding for ToggleCommandPalette(mode=commandline)
2. Having ToggleCommandPalette() switch between modes: closed->action->command line->closed.
3. Both of them ☺️

Proposed technical implementation details (optional)

The most straightforward solution is to add an optional command palette mode to the ToggleCommandPalette, with two "launch modes": action and command line.

We will be able to implement option 2 only once #8044 gets merged.

[zadjii-msft]

I'll be danged, I could have sworn I had already filed a task for this.

Ideas:

• I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the toggleCommandPalette(mode=commandline) keybinding, it'll pop you directly into commandline mode? (with Enable shortcut while CommandPalette is open #8044) (and vice versa)
• Action and commandline mode definitely, tab search maybe? I suppose { action: toggleCommandPalette, mode: tabSearch } doesn't really make sense now does it.

[DHowett]

I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

[Don-Vito]

I'll be danged, I could have sworn I had already filed a task for this.

Ideas:

* I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the `toggleCommandPalette(mode=commandline)` keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa)

* Action and commandline mode definitely, tab search maybe? I suppose `{ action: toggleCommandPalette, mode: tabSearch }` doesn't _really_ make sense now does it.

@zadjii-msft - I believe that:

• toggleCommandPalette(mode=commandline) - should work from everywhere (even if the window is minimized and the PC is hibernated)
• same for toggleCommandPalette(mode=commandline)
• while toggleCommandPalette() with no mode specified should rotate through the modes (closed->action->command line).

WDYT?

[Don-Vito]

I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

Yep.. that was a bad idea, especially since we already have a tabSeach binding...

[Don-Vito]

I'll be danged, I could have sworn I had already filed a task for this.

@zadjii-msft - I found it.. in the form of TODO 😆

 void TerminalPage::_HandleToggleCommandPalette(const IInspectable& /*sender*/,
                                                   const ActionEventArgs& args)
    {
        // TODO GH#6677: When we add support for commandline mode, first set the
        // mode that the command palette should be in, before making it visible.
        CommandPalette().EnableCommandPaletteMode();
        CommandPalette().Visibility(CommandPalette().Visibility() == Visibility::Visible ?
                                        Visibility::Collapsed :
                                        Visibility::Visible);
        args.Handled(true);
    }

[ghost]

🎉This issue was addressed in #8382, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

• Release Notes
• Store Download