Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launchMode parameter to ToggleCommandPalette action #8382

Merged
6 commits merged into from
Dec 3, 2020
Merged

Add launchMode parameter to ToggleCommandPalette action #8382

6 commits merged into from
Dec 3, 2020

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Nov 24, 2020 •
edited

PR Checklist

Detailed Description of the Pull Request / Additional comments

Added an optional launchMode parameter to "commandPalette" command.
The values of the launchMode are either "action" (default) or "command line".

Validation Steps Performed

  • Manual tests

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Nov 24, 2020
@Don-Vito Don-Vito changed the title Add launchMode parameter to the ToggleCommandPalette action Add launchMode parameter to ToggleCommandPalette action Nov 24, 2020
@Don-Vito Don-Vito marked this pull request as ready for review November 24, 2020 01:26
carlos-zamora
carlos-zamora reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @zadjii-msft will probably want to take a look at this. But this is a weird week because of Thanksgiving, so it may be a bit before some other team members get to it.

I'll approve after some discussion on the CommandPaletteMode thing below.

src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp-9d33445a Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/CommandPalette.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/CommandPalette.cpp Outdated
_switchToMode(CommandPaletteMode::ActionMode);
auto mode = (launchMode == CommandPaletteLaunchMode::CommandLine) ?
CommandPaletteMode::CommandlineMode :
CommandPaletteMode::ActionMode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could/Should we consolidate these into one CommandPaletteMode enum in ActionArgs.idl? That way we don't have to do this translation? Or is that a weird thing to do since the mode that the command palette is in isn't really a setting. (this one is more of a thought exercise than a "requested change")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought exercise already completed in #8322 (comment) and #8322 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Dustin mentioned, we didn't want to expose the entire enum, so I thought that the introduction of the new one was the simplest way to achieve this.

src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp Show resolved Hide resolved
@Don-Vito
Copy link
Contributor Author

Great work! @zadjii-msft will probably want to take a look at this. But this is a weird week because of Thanksgiving, so it may be a bit before some other team members get to it.

I'll approve after some discussion on the CommandPaletteMode thing below.

Thanks for the review! Will get to the fixes soon.
Mike already gave me a heads up about his vacation - so no pressure, this will be just yet another one waiting for him 😄
And probably it's not just this week being weird - with all the holidays and PTOs we might be back to normal just in mid-January 😄
Thanks again and happy Thanksgiving!

@Don-Vito Don-Vito force-pushed the 8322-commandpalette-mode-binding branch from af52b8a to 4466a26 Compare November 25, 2020 10:53
DHowett
DHowett approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Thanks so much.

Only nits, but since you have to rev the PR for code formatting reasons, I'll still sign off 😄

src/cascadia/TerminalApp/CommandPalette.h Outdated Show resolved Hide resolved
src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp Show resolved Hide resolved
@DHowett
Copy link
Member

DHowett commented Nov 25, 2020

(obligated to wait for docs pr, but this time we're only at one approval)

@Don-Vito
Copy link
Contributor Author

(obligated to wait for docs pr, but this time we're only at one approval)

Added documentation (though something very basic, but I believe it is better this way).

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 29, 2020 •
edited

@zadjii-msft - if you are here, please take a look 😊

zadjii-msft
zadjii-msft approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good to me. Thanks!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Dec 3, 2020

@DHowett - it seems that automerge fails

@DHowett
Copy link
Member

DHowett commented Dec 3, 2020

Oop lemme kick that build. Sorry!

@Don-Vito
Copy link
Contributor Author

Don-Vito commented Dec 3, 2020

Gods of CI please be kind with this one.. don't let it fail randomly..

@zadjii-msft
Copy link
Member

@ msftbot re-run the CI till it passes

I kid, we really should do something about these CI failures

@ghost ghost merged commit f072eaf into microsoft:main Dec 3, 2020
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Dec 3, 2020

@ msftbot re-run the CI till it passes

I kid, we really should do something about these CI failures

@zadjii-msft - it worked! I guess it is a combination of my prayers and the undocumented msftbot APIs 😆

@Don-Vito Don-Vito deleted the 8322-commandpalette-mode-binding branch December 3, 2020 16:58
@microsoft microsoft deleted a comment Dec 3, 2020
@cinnamon-msft cinnamon-msft mentioned this pull request Jan 22, 2021
Closed
15 tasks
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Don-Vito @DHowett @zadjii-msft @carlos-zamora