Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a preview of your terminal to the Settings UI #9122

Closed
carlos-zamora opened this issue Feb 11, 2021 · 2 comments · Fixed by #9527
Closed

Add a preview of your terminal to the Settings UI #9122

carlos-zamora opened this issue Feb 11, 2021 · 2 comments · Fixed by #9527
Assignees
@PankajBhojwani
Labels
Area-Settings UI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.9

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

Design doc link

It would be really cool if we had a preview of the terminal in the Settings UI > Profile > Appearance page and the Settings UI > Color Schemes page.

Implementation plan:

  • Move TerminalSettings to TerminalSettingsModel project
  • Introduce
  • In Settings UI...
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI labels Feb 11, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.8 milestone Feb 11, 2021
@carlos-zamora carlos-zamora self-assigned this Feb 11, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 11, 2021
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2021
Open
25 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 11, 2021
@carlos-zamora carlos-zamora mentioned this issue Mar 1, 2021
Merged
ghost pushed a commit that referenced this issue Mar 15, 2021
@carlos-zamora
Move TerminalSettings from TermApp to TerminalSettingsModel (#9318)
44f1ba6 
This accomplishes the first step towards embedding a preview on the Profiles/ColorSchemes page, by moving the `TerminalSettings` object over to the Terminal Settings Model project. We'll leverage this in a later PR to construct an embedded terminal in the settings UI.

`TerminalSettings` had to see a few more functions exposed in the IDL
(including some inheritance stuff).

Refresh the JSON to make TerminalSettings do it's thing across all the
open terminals.

References #9122 - Terminal Preview
References #6800 - SUI Epic
@PankajBhojwani PankajBhojwani mentioned this issue Mar 17, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 17, 2021
@carlos-zamora carlos-zamora removed their assignment Mar 29, 2021
DHowett pushed a commit that referenced this issue May 17, 2021
@PankajBhojwani
Show a preview of the control in the SUI (#9527)
f3cf321 
In the 'Appearance' tab of a profile, show a preview of what the control looks like

## PR Checklist
* [x] Closes #9122
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 17, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9527, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #9527, which has now been successfully released as Windows Terminal v1.9.1942.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.9
Development

Successfully merging a pull request may close this issue.

Show a preview of the control in the SUI microsoft/terminal
4 participants
@carlos-zamora @zadjii-msft @PankajBhojwani @cinnamon-msft