Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The LocalTests are broken, March 2021 edition #9659

Closed
3 tasks done
zadjii-msft opened this issue Mar 30, 2021 · 0 comments · Fixed by #9660
Closed
3 tasks done

The LocalTests are broken, March 2021 edition #9659

zadjii-msft opened this issue Mar 30, 2021 · 0 comments · Fixed by #9660
Assignees
@zadjii-msft
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.8

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 30, 2021 •
edited

Oh, no, they were broken even before this. Welp. looks like I'll be fruitlessly trying to bisect that today.

It was definitely defterm

Originally posted by @zadjii-msft in #9656 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 30, 2021
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Meta The product is the management of the products. labels Mar 30, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 30, 2021
@zadjii-msft zadjii-msft self-assigned this Mar 30, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.8 milestone Mar 30, 2021
zadjii-msft added a commit that referenced this issue Mar 30, 2021
@zadjii-msft
This fixes part of the tests
06b4168 
  Broadly, the tests were broken by #7489 because there were no _startupActions. They relied on the removed codepath that assumed wt.exe always set actions, or `AppCommandlineArgs::ValidateStartupCommands` created one by default.

  These tests are still broken:
  * `TerminalAppLocalTests::TabTests::TryZoomPane [Failed]`
  * `TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed]`
  * `TerminalAppLocalTests::TabTests::CloseZoomedPane [Failed]`

  Re:#9659
@zadjii-msft zadjii-msft mentioned this issue Mar 30, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 30, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 30, 2021
@ghost ghost closed this as completed in #9660 Mar 30, 2021
ghost pushed a commit that referenced this issue Mar 30, 2021
@zadjii-msft
Another fix for the localtests, March 2021 edition (#9660)
5ab78fc 
Broadly, the tests were broken by #7489 because there were no `_startupActions`. They relied on the removed codepath that assumed `wt.exe` always set actions, or `AppCommandlineArgs::ValidateStartupCommands` created one by default.

* [x] fixes #9659
* [x] I work here
* [x] the tests pass again
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 30, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.8
Development

Successfully merging a pull request may close this issue.

Another fix for the localtests, March 2021 edition microsoft/terminal
1 participant
@zadjii-msft