Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing renameWindow key binding types into terminal prompt #9803

Closed
cinnamon-msft opened this issue Apr 13, 2021 · 5 comments
Closed

Typing renameWindow key binding types into terminal prompt #9803

cinnamon-msft opened this issue Apr 13, 2021 · 5 comments
Assignees
@Don-Vito
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.9

Comments

@cinnamon-msft
Copy link
Contributor

Windows Terminal version (or Windows build number)

1.8.1022.0

Other Software

No response

Steps to reproduce

Add this key binding to your actions:

{ "command": { "action": "renameWindow", "name": "Foo" }, "keys": "ctrl+u" },

Expected Behavior

Nothing should be typed into the prompt.

Actual Behavior

It's renaming the window and also typing into my prompt.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 13, 2021
@cinnamon-msft cinnamon-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 14, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 14, 2021
@Don-Vito
Copy link
Contributor

On it.

@zadjii-msft zadjii-msft self-assigned this Apr 14, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 14, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.9 milestone Apr 14, 2021
@Don-Vito
Copy link
Contributor

@zadjii-msft - you can assign this to me - so you need one reviewer less
I will finish it today.

@zadjii-msft
Copy link
Member

Oh okay sure, it's definitely a oneline fix haha

@zadjii-msft zadjii-msft assigned Don-Vito and unassigned zadjii-msft Apr 14, 2021
@Don-Vito Don-Vito mentioned this issue Apr 14, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 14, 2021
@ghost ghost closed this as completed in cdbcc17 Apr 14, 2021
mpela81 pushed a commit to mpela81/terminal that referenced this issue Apr 17, 2021
@Don-Vito @mpela81
Fix rename window handler to mark action as handled (microsoft#9809)
4d57b23 
## PR Checklist
* [x] Closes microsoft#9803
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated. 
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.
DHowett pushed a commit that referenced this issue May 14, 2021
@Don-Vito @DHowett
Fix rename window handler to mark action as handled (#9809)
89032b8 
## PR Checklist
* [x] Closes #9803
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit cdbcc17)
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9809, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9809, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Vito Don-Vito

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.9
Development

No branches or pull requests
3 participants
@Don-Vito @zadjii-msft @cinnamon-msft