Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab closes on middle button mousedown rather than full click #9836

Closed
lbmaian opened this issue Apr 15, 2021 · 5 comments
Closed

Tab closes on middle button mousedown rather than full click #9836

lbmaian opened this issue Apr 15, 2021 · 5 comments
Labels
good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@lbmaian
Copy link

lbmaian commented Apr 15, 2021

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

  1. Open a new tab
  2. Middle button mousedown on the tab itself

Expected Behavior

Tab does not close until middle button mouseup on the same tab occurs, i.e. a full middle button click action.

This is the most typical behavior for tab closing in tabbed applications (web browsers, IDEs, etc.).

Actual Behavior

Tab closes immediately on middle button mousedown, without waiting for middle button mouseup on the same tab.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 15, 2021
@skyline75489
Copy link
Collaborator

Huh it is true. I can easily repro this. Perhaps we should move this to upstream repo.

@zadjii-msft
Copy link
Member

This might not be on WinUI. Looks like we're the one's that did it on PointerPressed, not PointerReleased. See TerminalPage::_OnTabClick

@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 15, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 15, 2021
@Don-Vito Don-Vito mentioned this issue Apr 15, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Apr 15, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 15, 2021
@lbmaian
Copy link
Author

lbmaian commented Apr 15, 2021

Also something to point out:

Most tabbed interfaces (including Chrome, Edge, Firefox, Visual Studio Code) require that mousedown happen on the button, then subsequent mouseup on the same button, allowing pointer to move outside the button while button is still held down as long as it returns to the button when the mouseup happens.

Others (including Notepad++) only require mouseup on the button, without requiring mousedown on that button, i.e. pointer can be off the button when mousedown happens, move pointer over button, then mouseup.

Aside: I found Visual Studio (not VS Code) tabs also close on middle mousedown.

mpela81 pushed a commit to mpela81/terminal that referenced this issue Apr 17, 2021
@Don-Vito @mpela81
Delay close tab on middle-click till pointer released (microsoft#9842)
e1b6440 
## PR Checklist
* [x] Closes microsoft#9836
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. 

Not sure what is the reason for handling right button. 
But delaying it to PointerReleased seems not to regress anything.
DHowett pushed a commit that referenced this issue May 14, 2021
@Don-Vito @DHowett
Delay close tab on middle-click till pointer released (#9842)
9e93ccb 
* [x] Closes #9836
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

Not sure what is the reason for handling right button.
But delaying it to PointerReleased seems not to regress anything.

(cherry picked from commit 05e7ea1)
DHowett pushed a commit that referenced this issue May 14, 2021
@Don-Vito @DHowett
Delay close tab on middle-click till pointer released (#9842)
ac864d2 
## PR Checklist
* [x] Closes #9836
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

Not sure what is the reason for handling right button.
But delaying it to PointerReleased seems not to regress anything.

(cherry picked from commit 05e7ea1)
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9842, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9842, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
3 participants
@skyline75489 @zadjii-msft @lbmaian