Very long ToolTips get clipped

[vadimkantorov]

The current directory of WSLv1 tab is /mnt/c/Users/user/Downloads, and the tooltip just reads /mnt. This is not useful since it's very generic, even /mnt/c would be more useful. Maybe even absence of this strange path would be less confusing.

Terminal version: Version: 1.7.1033.0

[DHowett]

It just looks like it’s cut off (look at the part of the character to the right of mnt). We should probably fix that.

[vadimkantorov]

If the tooltip is already multiline, maybe best to always put this path / PS1 it on new line (as well as the PS1 prompt), And then it could be ellipse'd... Maybe some heuristics could be used, such as putting the first occurred slash on the new line

Or maybe the tooltip could have increased width (even maybe matching the window width).

[DHowett]

So, we don’t actually know that it’s a path. That’s the verbatim string that bash reported to us, with the username/hostname/path pre-formatted. Alas.

[vadimkantorov]

Summing up three other variants: 1) show PS1 on different line than OS name, 2) make tooltip radically larger, 3) have some heuristics for word-wrapping unknown PS1 (e.g. by slash or non-word characters)

[zadjii-msft]

Hmm, it looks like how we're building the tooltips doesn't account for the width of the text:

But then compare to:

  <Button Content="Button with a simple ToolTip."
        ToolTipService.ToolTip="https://this.com/is/a/incredibly-long-hyperlink/that/might/have/too-long-a-tooltip"/>

So TabBase::_UpdateToolTip and

    <Border x:Name="HyperlinkTooltipBorder"
            BorderBrush="Transparent">
        <ToolTipService.ToolTip>
            <ToolTip x:Name="LinkTip"
                     Placement="Mouse">
                <TextBlock IsTextSelectionEnabled="True">
                    <Run x:Name="HoveredUri" /> <LineBreak />
                    <Run x:Uid="HowToOpenRun"
                         FontStyle="Italic" />
                </TextBlock>
            </ToolTip>
        </ToolTipService.ToolTip>
    </Border>

in termcontrol.xaml will probably need to get updated.

[vadimkantorov]

Also, not sure why ctrl+alt+2 shows up at a seemingly arbitrary margin (not left, not right, unclear the intent). With combination with a clipped tooltip, this looks also strange

Also note that ctrl is captialized differently in ctrl+alt+2 and in Ctrl+Click - seems inconsistent

[zadjii-msft]

The ctrl+alt+2 is probably trying to center itself underneath the previous line of text. It just doesn't realize that it's container is not as big as the text is 😉

[vadimkantorov]

My proposed tooltip (consistent captialization + PS1 on new line always + FS path wrapping heuristic for the first slash (so that for default Windows/Ubuntu PS1 scheme it looks okay in for short enough paths) + wrapping is prefixed by "... ":

[Ctrl+Alt+2]: Ubuntu 18.04
vadimkantorov@DESKTOP-4UF8FID:
... /mnt/c/Users/user
.... more wrapping if needed

[Don-Vito]

As the one responsible for the mess, I can take a look later on.

[Don-Vito]

I will start with fixing the wrapping (one-liner).
@zadjii-msft - please let me know if you want to switch to another structure, like @vadimkantorov suggested.

[zadjii-msft]

Nah, let's just fix the wrapping for now. That's easiest - everything else is just heuristics, which is a programmer word for "guessing" 😄 Plus, that doesn't involve any real design changes, which would require a much lengthier discussion

[vadimkantorov]

Will this also fix Ctrl capitalization + shortcut placement?

[Don-Vito]

@vadimkantorov - no, I didn't fix any of those, sorry.

• Regarding the shortcut placement, @zadjii-msft - advised to leave it as is meanwhile
• Regarding the capitalization we need to do it.. but I guess it has larger scope that just a tool-tip, e.g., it might affect the command palette as well.

[ghost]

🎉This issue was addressed in #9913, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

• Release Notes
• Store Download

[Korb]

The tooltip for the new tab button is too short (or the text is too long) to understand what it says:

Windows Terminal Preview 1.12.2931.0, Microsoft Windows 10.0.19043.1387.

Related #5355 and #5484.