Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Double Click Selection #988

Closed
carlos-zamora opened this issue May 24, 2019 · 6 comments
Closed

Feature Request: Double Click Selection #988

carlos-zamora opened this issue May 24, 2019 · 6 comments
Assignees
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Milestone

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented May 24, 2019

Summary of the new feature/enhancement

Double-clicking the text buffer creates a selection encompassing the "word".
The delimiters for what makes a "word" are defined in the settings (described below).

Dragging after a double click maintains the "beginning of the word" anchor but changes the other one.

Settings

Property Name Type Description Default Value
"selectionDelimiters" array list of characters used as delimiters [' ', '/', '\']

Use case: easily select a path or word from the selection.

Proposed technical implementation details (optional)

If possible, have XAML identify double-click. Everything else should be pretty straightforward. The TermControl will work with the Terminal to create the selection. When the event is triggered, we need to check the delimiters from the settings to decide what to select.

@carlos-zamora carlos-zamora added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@carlos-zamora carlos-zamora self-assigned this May 24, 2019
@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Work-Item It's being tracked by an actual work item internally. (to be removed soon) and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2019
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone May 24, 2019
@mdtauk
Copy link

mdtauk commented May 24, 2019

Would this support double clicking to select an entire word? Or just double click to switch to mouse selection mode?

@carlos-zamora
Copy link
Member Author

Would this support double clicking to select an entire word? Or just double click to switch to mouse selection mode?

Assuming the window is focused and you're already in mouse selection mode, it should select the entire word (inclusive).

@mikepurvis
Copy link

Double click and drag is also important— like current PowerShell, it should be possible to select a line or word and then drag out to encompass more text.

@carlos-zamora carlos-zamora added the In-PR This issue has a related PR label Jul 5, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 12, 2019
@andb0t
Copy link

andb0t commented Jul 12, 2019

Wow, great job everyone! Could you let me know how I can find out when this change will actually be rolled out?

@carlos-zamora
Copy link
Member Author

Since it’s merged to master, you can try it out by building the repo on GitHub today.

For the store update, it’ll be in the next release that’s being tracked with the 0.3 milestone.

@Luuk34
Copy link

Luuk34 commented Aug 3, 2019

Double click does not work when double-clicking on the first character of a line
(tested in Version 0.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Projects
None yet
Development

No branches or pull requests

6 participants